fix: do not allow child windows to specify their own preload script (electron#23226)

MarshallOfSound · web-flow · commit 375b79398439 · 2020-04-22T12:43:21.000-07:00
diff --git a/lib/common/parse-features-string.ts b/lib/common/parse-features-string.ts
@@ -75,7 +75,7 @@ export function parseWebViewWebPreferences (preferences: string) {
   return parseCommaSeparatedKeyValue(preferences, false).parsed;
 }
 
-const allowedWebPreferences = ['zoomFactor', 'nodeIntegration', 'enableRemoteModule', 'preload', 'javascript', 'contextIsolation', 'webviewTag'] as const;
+const allowedWebPreferences = ['zoomFactor', 'nodeIntegration', 'enableRemoteModule', 'javascript', 'contextIsolation', 'webviewTag'] as const;
 type AllowedWebPreference = (typeof allowedWebPreferences)[number];
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export function parseWebViewWebPreferences (preferences: string) {`
`75`	`75`	`return parseCommaSeparatedKeyValue(preferences, false).parsed;`
`76`	`76`	`}`
`77`	`77`
`78`		`-const allowedWebPreferences = ['zoomFactor', 'nodeIntegration', 'enableRemoteModule', 'preload', 'javascript', 'contextIsolation', 'webviewTag'] as const;`
	`78`	`+const allowedWebPreferences = ['zoomFactor', 'nodeIntegration', 'enableRemoteModule', 'javascript', 'contextIsolation', 'webviewTag'] as const;`
`79`	`79`	`type AllowedWebPreference = (typeof allowedWebPreferences)[number];`
`80`	`80`
`81`	`81`	`/**`