fix: don't copy tray image when it's set (electron#20935)

trop[bot] · MarshallOfSound · commit 37c1df6ce111 · 2019-11-04T14:17:15.000-08:00
diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm
@@ -87,12 +87,12 @@ - (void)removeItem {
 }
 
 - (void)setImage:(NSImage*)image {
-  [[statusItem_ button] setImage:[image copy]];
+  [[statusItem_ button] setImage:image];
   [self updateDimensions];
 }
 
 - (void)setAlternateImage:(NSImage*)image {
-  [[statusItem_ button] setAlternateImage:[image copy]];
+  [[statusItem_ button] setAlternateImage:image];
 }
 
 - (void)setIgnoreDoubleClickEvents:(BOOL)ignore {
@@ -108,7 +108,7 @@ - (void)setTitle:(NSString*)title {
     [[statusItem_ button]
         setAttributedTitle:[title attributedStringParsingANSICodes]];
   } else {
-    [[statusItem_ button] setTitle:[title copy]];
+    [[statusItem_ button] setTitle:title];
   }
 
   // Fix icon margins.

Original file line number	Diff line number	Diff line change
`@@ -87,12 +87,12 @@ - (void)removeItem {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`- (void)setImage:(NSImage*)image {`
`90`		`- [[statusItem_ button] setImage:[image copy]];`
	`90`	`+ [[statusItem_ button] setImage:image];`
`91`	`91`	`[self updateDimensions];`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`- (void)setAlternateImage:(NSImage*)image {`
`95`		`- [[statusItem_ button] setAlternateImage:[image copy]];`
	`95`	`+ [[statusItem_ button] setAlternateImage:image];`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`- (void)setIgnoreDoubleClickEvents:(BOOL)ignore {`
`@@ -108,7 +108,7 @@ - (void)setTitle:(NSString*)title {`
`108`	`108`	`[[statusItem_ button]`
`109`	`109`	`setAttributedTitle:[title attributedStringParsingANSICodes]];`
`110`	`110`	`} else {`
`111`		`- [[statusItem_ button] setTitle:[title copy]];`
	`111`	`+ [[statusItem_ button] setTitle:title];`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`// Fix icon margins.`