Skip to content

Commit 66b407e

Browse files
trop[bot]John Kleinschmidt
andauthored
build: use correct v8_context_snapshot_generator in mksnapshot zip (electron#23539)
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
1 parent cb2248e commit 66b407e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.circleci/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,10 @@ step-mksnapshot-build: &step-mksnapshot-build
542542
if [ "`uname`" != "Darwin" ]; then
543543
if [ "$TARGET_ARCH" == "arm" ]; then
544544
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/mksnapshot
545+
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/v8_context_snapshot_generator
545546
elif [ "$TARGET_ARCH" == "arm64" ]; then
546547
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/mksnapshot
548+
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/v8_context_snapshot_generator
547549
else
548550
electron/script/strip-binaries.py --file $PWD/out/Default/mksnapshot
549551
electron/script/strip-binaries.py --file $PWD/out/Default/v8_context_snapshot_generator

BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,7 @@ dist_zip("electron_chromedriver_zip") {
12911291

12921292
mksnapshot_deps = [
12931293
":licenses",
1294-
"//tools/v8_context_snapshot:v8_context_snapshot_generator",
1294+
"//tools/v8_context_snapshot:v8_context_snapshot_generator($v8_snapshot_toolchain)",
12951295
"//v8:mksnapshot($v8_snapshot_toolchain)",
12961296
]
12971297

0 commit comments

Comments
 (0)