Skip to content

Commit 83e7b00

Browse files
authored
fix: prevent crash in ListValue v8 converter when conversion fails (electron#22757)
1 parent eabb872 commit 83e7b00

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

shell/common/native_mate_converters/value_converter.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
5858
electron::V8ValueConverter converter;
5959
std::unique_ptr<base::Value> value(
6060
converter.FromV8Value(val, isolate->GetCurrentContext()));
61-
if (value->is_list()) {
61+
if (value && value->is_list()) {
6262
out->Swap(static_cast<base::ListValue*>(value.get()));
6363
return true;
6464
} else {

0 commit comments

Comments
 (0)