Skip to content

Commit 9d60cfa

Browse files
fix: do not double-declare webPreferences (electron#23223)
1 parent c798a6e commit 9d60cfa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/browser/guest-window-manager.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ const canAccessWindow = function (sender, target) {
220220
// Routed window.open messages with raw options
221221
ipcMainInternal.on('ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_OPEN', (event, url, frameName, features) => {
222222
// This should only be allowed for senders that have nativeWindowOpen: false
223-
const webPreferences = event.sender.getLastWebPreferences();
224-
if (webPreferences.nativeWindowOpen || webPreferences.sandbox) {
223+
const lastWebPreferences = event.sender.getLastWebPreferences();
224+
if (lastWebPreferences.nativeWindowOpen || lastWebPreferences.sandbox) {
225225
event.returnValue = null;
226226
throw new Error('GUEST_WINDOW_MANAGER_WINDOW_OPEN denied: expected native window.open');
227227
}

0 commit comments

Comments
 (0)