ci: add macOS debug builds (electron#20572)

trop[bot] · codebytere · commit a12de693b08e · 2019-10-15T09:14:25.000-07:00
* ci: add macOS debug builds

* Fix mac debug builds

* Remove ninja status as it is not available in 6-0-x
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -640,9 +640,11 @@ steps-electron-build-for-tests: &steps-electron-build-for-tests
     - *step-depot-tools-add-to-path
     - *step-setup-env-for-build
     - *step-restore-brew-cache
+    - *step-get-more-space-on-mac
     - *step-install-npm-deps-on-mac
     - *step-fix-sync-on-mac
     - *step-gn-gen-default
+    - *step-delete-git-directories
 
     # Electron app
     - *step-electron-build
@@ -1099,6 +1101,14 @@ jobs:
       <<: *env-enable-sccache
     <<: *steps-electron-build-for-tests
 
+  osx-debug:
+    <<: *machine-mac-large
+    environment:
+      <<: *env-mac-large
+      <<: *env-debug-build
+      <<: *env-enable-sccache
+    <<: *steps-electron-build-for-tests    
+
   osx-debug-gn-check:
     <<: *machine-mac
     environment:
@@ -1147,6 +1157,15 @@ jobs:
       <<: *env-enable-sccache
     <<: *steps-electron-build-for-tests
 
+  mas-debug:
+    <<: *machine-mac-large
+    environment:
+      <<: *env-mac-large
+      <<: *env-mas
+      <<: *env-debug-build
+      <<: *env-enable-sccache
+    <<: *steps-electron-build-for-tests
+
   mas-debug-gn-check:
     <<: *machine-mac
     environment:
@@ -1470,9 +1489,14 @@ workflows:
           requires:
             - mac-checkout
 
+      - osx-debug:
+          requires:
+            - mac-checkout
+
       - osx-debug-gn-check:
           requires:
             - mac-checkout
+
       - osx-testing-gn-check:
           requires:
             - mac-checkout
@@ -1485,9 +1509,14 @@ workflows:
           requires:
             - mac-checkout
 
+      - mas-debug:
+          requires:
+            - mac-checkout
+
       - mas-debug-gn-check:
           requires:
             - mac-checkout
+
       - mas-testing-gn-check:
           requires:
             - mac-checkout
diff --git a/BUILD.gn b/BUILD.gn
@@ -657,9 +657,7 @@ static_library("electron_lib") {
   }
 
   if (enable_desktop_capturer) {
-    if (is_component_build && is_win) {
-      # On windows the implementation relies on unexported
-      # DxgiDuplicatorController class.
+    if (is_component_build && !is_linux) {
       deps += [ "//third_party/webrtc/modules/desktop_capture" ]
     }
     sources += [

Original file line number	Diff line number	Diff line change
`@@ -657,9 +657,7 @@ static_library("electron_lib") {`
`657`	`657`	`}`
`658`	`658`
`659`	`659`	`if (enable_desktop_capturer) {`
`660`		`- if (is_component_build && is_win) {`
`661`		`- # On windows the implementation relies on unexported`
`662`		`- # DxgiDuplicatorController class.`
	`660`	`+ if (is_component_build && !is_linux) {`
`663`	`661`	`deps += [ "//third_party/webrtc/modules/desktop_capture" ]`
`664`	`662`	`}`
`665`	`663`	`sources += [`