build: use libc++ for nan tests

MarshallOfSound · MarshallOfSound · commit e79f34c03bc8 · 2020-10-26T18:02:29.000-07:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -680,6 +680,7 @@ step-persist-data-for-tests: &step-persist-data-for-tests
       - src/third_party/electron_node
       - src/third_party/nan
       - src/third_party/llvm-build
+      - src/build/linux
 
 step-electron-dist-unzip: &step-electron-dist-unzip
   run:
diff --git a/script/nan-spec-runner.js b/script/nan-spec-runner.js
@@ -17,16 +17,28 @@ const args = require('minimist')(process.argv.slice(2), {
   string: ['only']
 });
 
+function getSDKRoot () {
+  if (process.env.SDKROOT) return process.env.SDKROOT;
+  const output = cp.execFileSync('xcrun', ['--sdk', 'macosx', '--show-sdk-path']);
+  return output.toString().trim();
+}
+
 async function main () {
   const nodeDir = path.resolve(BASE, `out/${utils.getOutDir({ shouldLog: true })}/gen/node_headers`);
   const env = Object.assign({}, process.env, {
     npm_config_nodedir: nodeDir,
     npm_config_msvs_version: '2019',
     npm_config_arch: process.env.NPM_CONFIG_ARCH
   });
-  if (process.platform === 'linux') {
-    env.CC = `"${path.resolve(__dirname, '..', '../third_party/llvm-build/Release+Asserts/bin/clang')}"`;
-    env.CXX = `"${path.resolve(__dirname, '..', '../third_party/llvm-build/Release+Asserts/bin/clang++')}"`;
+  const clangArgs = [];
+  if (process.platform === 'darwin') {
+    clangArgs.push('-isysroot', getSDKRoot());
+  }
+  clangArgs.push('-std=c++14', '-stdlib=libc++');
+
+  if (process.platform !== 'win32') {
+    env.CC = `"${path.resolve(__dirname, '..', '../third_party/llvm-build/Release+Asserts/bin/clang')}" ${clangArgs.join(' ')}`;
+    env.CXX = `"${path.resolve(__dirname, '..', '../third_party/llvm-build/Release+Asserts/bin/clang++')}" ${clangArgs.join(' ')}`;
   }
   const { status: buildStatus } = cp.spawnSync(NPX_CMD, ['node-gyp', 'rebuild', '--directory', 'test', '-j', 'max'], {
     env,
