Fix faulty node_modules portability caching logic.

Ben Newman · Ben Newman · commit 1880d76a8cf8 · 2016-03-14T20:35:33.000-04:00
diff --git a/tools/isobuild/meteor-npm.js b/tools/isobuild/meteor-npm.js
@@ -147,13 +147,13 @@ meteorNpm.dependenciesArePortable = function (nodeModulesDir) {
           // away the next time those packages are (re)installed.
           const portableFile = files.pathJoin(item, ".meteor-portable");
           if (files.exists(portableFile)) {
-            return JSON.parse(files.readFile(portableFile));
+            return ! JSON.parse(files.readFile(portableFile));
           }
-          const portable = ! search(item);
-          files.writeFile(portableFile, JSON.stringify(portable) + "\n");
-          return portable;
+          const result = search(item);
+          files.writeFile(portableFile, JSON.stringify(! result) + "\n");
+          return result;
         }
-        return ! search(item);
+        return search(item);
       }
     }) || false;
   };

Original file line number	Diff line number	Diff line change
`@@ -147,13 +147,13 @@ meteorNpm.dependenciesArePortable = function (nodeModulesDir) {`
`147`	`147`	`// away the next time those packages are (re)installed.`
`148`	`148`	`const portableFile = files.pathJoin(item, ".meteor-portable");`
`149`	`149`	`if (files.exists(portableFile)) {`
`150`		`- return JSON.parse(files.readFile(portableFile));`
	`150`	`+ return ! JSON.parse(files.readFile(portableFile));`
`151`	`151`	`}`
`152`		`- const portable = ! search(item);`
`153`		`- files.writeFile(portableFile, JSON.stringify(portable) + "\n");`
`154`		`- return portable;`
	`152`	`+ const result = search(item);`
	`153`	`+ files.writeFile(portableFile, JSON.stringify(! result) + "\n");`
	`154`	`+ return result;`
`155`	`155`	`}`
`156`		`- return ! search(item);`
	`156`	`+ return search(item);`
`157`	`157`	`}`
`158`	`158`	`}) \|\| false;`
`159`	`159`	`};`