Fall back to async for EPERM errors in files.rm_recursive.

Ben Newman · Ben Newman · commit 9e60539f113a · 2018-01-16T11:05:40.000-05:00
Previously, the async fallback was only used in case of ENOTEMPTY errors, but Windows appears to throw temporary EPERM errors as well. If the errors are actually robust/non-temporary, the async version will fail, too. Should help with meteor#9540.
diff --git a/tools/fs/files.js b/tools/fs/files.js
@@ -310,7 +310,9 @@ files.rm_recursive = Profile("files.rm_recursive", (path) => {
   try {
     rimraf.sync(files.convertToOSPath(path));
   } catch (e) {
-    if (e.code === "ENOTEMPTY" && canYield()) {
+    if ((e.code === "ENOTEMPTY" ||
+         e.code === "EPERM") &&
+        canYield()) {
       files.rm_recursive_async(path).await();
       return;
     }
