refactor(babel-preset-app): remove babel-plugin-dynamic-import-node (nuxt#6197)

clarkdo · Pooya Parsa · commit c436839a17f7 · 2019-08-08T13:39:17.000+04:30
diff --git a/babel.config.js b/babel.config.js
@@ -11,8 +11,7 @@ module.exports = function (api) {
             node: 'current'
           }
         }]
-      ],
-      plugins: ['dynamic-import-node']
+      ]
     }
   }
   return {}
diff --git a/package.json b/package.json
@@ -37,7 +37,6 @@
     "@vue/test-utils": "^1.0.0-beta.29",
     "babel-eslint": "^10.0.2",
     "babel-jest": "^24.8.0",
-    "babel-plugin-dynamic-import-node": "^2.3.0",
     "cheerio": "^1.0.0-rc.3",
     "codecov": "^3.5.0",
     "consola": "^2.10.0",
diff --git a/packages/babel-preset-app/README.md b/packages/babel-preset-app/README.md
@@ -4,7 +4,7 @@
 
 ## Usage
 
-This is the default preset used by Nuxt, which is mainly a wrapper around the `@babel/preset-env` preset. It also optionally uses the `@vue/babel-preset-jsx` preset as well as `@babel/plugin-syntax-dynamic-import`, `@babel/plugin-proposal-decorators`, `@babel/plugin-proposal-class-properties`, `@babel/plugin-transform-runtime`. Furthermore the preset is adding polyfills.
+This is the default preset used by Nuxt, which is mainly a wrapper around the `@babel/preset-env` preset. It also optionally uses the `@vue/babel-preset-jsx` preset as well as `@babel/plugin-proposal-decorators`, `@babel/plugin-proposal-class-properties`, `@babel/plugin-transform-runtime`. Furthermore the preset is adding polyfills.
 
 **Note**: Since `core-js@2` and `core-js@3` are both supported from Babel 7.4.0, we recommend directly adding `core-js` and setting the version via the [`corejs`](#corejs) option.
 
diff --git a/packages/babel-preset-app/package.json b/packages/babel-preset-app/package.json
@@ -13,7 +13,6 @@
     "@babel/core": "^7.5.5",
     "@babel/plugin-proposal-class-properties": "^7.5.5",
     "@babel/plugin-proposal-decorators": "^7.4.4",
-    "@babel/plugin-syntax-dynamic-import": "^7.2.0",
     "@babel/plugin-transform-runtime": "^7.5.5",
     "@babel/preset-env": "^7.5.5",
     "@babel/runtime": "^7.5.5",
diff --git a/packages/babel-preset-app/src/index.js b/packages/babel-preset-app/src/index.js
@@ -120,7 +120,6 @@ module.exports = (context, options = {}) => {
   }
 
   plugins.push(
-    require('@babel/plugin-syntax-dynamic-import'),
     [require('@babel/plugin-proposal-decorators'), {
       decoratorsBeforeExport,
       legacy: decoratorsLegacy !== false

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,7 @@ module.exports = function (api) {`
`11`	`11`	`node: 'current'`
`12`	`12`	`}`
`13`	`13`	`}]`
`14`		`- ],`
`15`		`- plugins: ['dynamic-import-node']`
	`14`	`+ ]`
`16`	`15`	`}`
`17`	`16`	`}`
`18`	`17`	`return {}`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,6 @@ module.exports = (context, options = {}) => {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`plugins.push(`
`123`		`- require('@babel/plugin-syntax-dynamic-import'),`
`124`	`123`	`[require('@babel/plugin-proposal-decorators'), {`
`125`	`124`	`decoratorsBeforeExport,`
`126`	`125`	`legacy: decoratorsLegacy !== false`