fix strict null checks in remoteAgentServiceImpl

joaomoreno · joaomoreno · commit 3fc698a8f831 · 2018-11-13T15:04:18.000+01:00
diff --git a/src/vs/workbench/services/remote/electron-browser/remoteAgentServiceImpl.ts b/src/vs/workbench/services/remote/electron-browser/remoteAgentServiceImpl.ts
@@ -61,7 +61,7 @@ class RemoteAgentConnection extends Disposable implements IRemoteAgentConnection
 
 			// Let's cover the case where connecting to fetch the remote extension info fails
 			this._environment = client.getEnvironmentData(this.remoteAuthority, this._environmentService.extensionDevelopmentLocationURI)
-				.then(null, err => { this._notificationService.error(localize('connectionError', "Failed to connect to the remote extension host agent (Error: {0})", err ? err.message : '')); return null; });
+				.then(undefined, err => { this._notificationService.error(localize('connectionError', "Failed to connect to the remote extension host agent (Error: {0})", err ? err.message : '')); return null; });
 		}
 		return this._environment;
 	}

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class RemoteAgentConnection extends Disposable implements IRemoteAgentConnection`
`61`	`61`
`62`	`62`	`// Let's cover the case where connecting to fetch the remote extension info fails`
`63`	`63`	`this._environment = client.getEnvironmentData(this.remoteAuthority, this._environmentService.extensionDevelopmentLocationURI)`
`64`		`- .then(null, err => { this._notificationService.error(localize('connectionError', "Failed to connect to the remote extension host agent (Error: {0})", err ? err.message : '')); return null; });`
	`64`	`+ .then(undefined, err => { this._notificationService.error(localize('connectionError', "Failed to connect to the remote extension host agent (Error: {0})", err ? err.message : '')); return null; });`
`65`	`65`	`}`
`66`	`66`	`return this._environment;`
`67`	`67`	`}`