fix microsoft#98138

sandy081 · sandy081 · commit ebaa7b5ff86f · 2020-05-21T01:57:55.000+02:00
diff --git a/src/vs/workbench/services/configuration/common/configurationEditingService.ts b/src/vs/workbench/services/configuration/common/configurationEditingService.ts
@@ -525,11 +525,13 @@ export class ConfigurationEditingService {
 				const model = reference.object.textEditorModel;
 
 				if (this.hasParseErrors(model, operation)) {
+					reference.dispose();
 					return this.reject<typeof reference>(ConfigurationEditingErrorCode.ERROR_INVALID_CONFIGURATION, target, operation);
 				}
 
 				// Target cannot be dirty if not writing into buffer
 				if (checkDirty && operation.resource && this.textFileService.isDirty(operation.resource)) {
+					reference.dispose();
 					return this.reject<typeof reference>(ConfigurationEditingErrorCode.ERROR_CONFIGURATION_FILE_DIRTY, target, operation);
 				}
 				return reference;

Original file line number	Diff line number	Diff line change
`@@ -525,11 +525,13 @@ export class ConfigurationEditingService {`
`525`	`525`	`const model = reference.object.textEditorModel;`
`526`	`526`
`527`	`527`	`if (this.hasParseErrors(model, operation)) {`
	`528`	`+ reference.dispose();`
`528`	`529`	`return this.reject<typeof reference>(ConfigurationEditingErrorCode.ERROR_INVALID_CONFIGURATION, target, operation);`
`529`	`530`	`}`
`530`	`531`
`531`	`532`	`// Target cannot be dirty if not writing into buffer`
`532`	`533`	`if (checkDirty && operation.resource && this.textFileService.isDirty(operation.resource)) {`
	`534`	`+ reference.dispose();`
`533`	`535`	`return this.reject<typeof reference>(ConfigurationEditingErrorCode.ERROR_CONFIGURATION_FILE_DIRTY, target, operation);`
`534`	`536`	`}`
`535`	`537`	`return reference;`