Skip to content

Commit fe06af8

Browse files
committed
refactor extensions management
- move extensions scanning
1 parent 674b549 commit fe06af8

File tree

5 files changed

+404
-319
lines changed

5 files changed

+404
-319
lines changed

src/vs/platform/extensionManagement/common/extensionManagement.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,12 @@ export const INSTALL_ERROR_NOT_SUPPORTED = 'notsupported';
187187
export const INSTALL_ERROR_MALICIOUS = 'malicious';
188188
export const INSTALL_ERROR_INCOMPATIBLE = 'incompatible';
189189

190+
export class ExtensionManagementError extends Error {
191+
constructor(message: string, readonly code: string) {
192+
super(message);
193+
}
194+
}
195+
190196
export interface IExtensionManagementService {
191197
_serviceBrand: undefined;
192198

@@ -196,7 +202,7 @@ export interface IExtensionManagementService {
196202
onDidUninstallExtension: Event<DidUninstallExtensionEvent>;
197203

198204
zip(extension: ILocalExtension): Promise<URI>;
199-
unzip(zipLocation: URI, type: ExtensionType): Promise<IExtensionIdentifier>;
205+
unzip(zipLocation: URI): Promise<IExtensionIdentifier>;
200206
getManifest(vsix: URI): Promise<IExtensionManifest>;
201207
install(vsix: URI): Promise<ILocalExtension>;
202208
installFromGallery(extension: IGalleryExtension): Promise<ILocalExtension>;

src/vs/platform/extensionManagement/common/extensionManagementIpc.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class ExtensionManagementChannel implements IServerChannel {
6060
const uriTransformer: IURITransformer | null = this.getUriTransformer(context);
6161
switch (command) {
6262
case 'zip': return this.service.zip(transformIncomingExtension(args[0], uriTransformer)).then(uri => transformOutgoingURI(uri, uriTransformer));
63-
case 'unzip': return this.service.unzip(transformIncomingURI(args[0], uriTransformer), args[1]);
63+
case 'unzip': return this.service.unzip(transformIncomingURI(args[0], uriTransformer));
6464
case 'install': return this.service.install(transformIncomingURI(args[0], uriTransformer));
6565
case 'getManifest': return this.service.getManifest(transformIncomingURI(args[0], uriTransformer));
6666
case 'installFromGallery': return this.service.installFromGallery(args[0]);
@@ -92,8 +92,8 @@ export class ExtensionManagementChannelClient implements IExtensionManagementSer
9292
return Promise.resolve(this.channel.call('zip', [extension]).then(result => URI.revive(<UriComponents>result)));
9393
}
9494

95-
unzip(zipLocation: URI, type: ExtensionType): Promise<IExtensionIdentifier> {
96-
return Promise.resolve(this.channel.call('unzip', [zipLocation, type]));
95+
unzip(zipLocation: URI): Promise<IExtensionIdentifier> {
96+
return Promise.resolve(this.channel.call('unzip', [zipLocation]));
9797
}
9898

9999
install(vsix: URI): Promise<ILocalExtension> {

0 commit comments

Comments
 (0)