keep-alive re-activated component should get updated props (fix vuejs#4237)

yyx990803 · yyx990803 · commit b60cd834660f · 2016-11-18T20:38:33.000-05:00
diff --git a/src/core/vdom/create-component.js b/src/core/vdom/create-component.js
@@ -154,6 +154,9 @@ function init (vnode: VNodeWithData, hydrating: boolean) {
   if (!vnode.child || vnode.child._isDestroyed) {
     const child = vnode.child = createComponentInstanceForVnode(vnode, activeInstance)
     child.$mount(hydrating ? vnode.elm : undefined, hydrating)
+  } else if (vnode.data.keepAlive) {
+    // kept-alive components, treat as a patch
+    prepatch(vnode, vnode)
   }
 }
 
diff --git a/test/unit/features/component/component-keep-alive.spec.js b/test/unit/features/component/component-keep-alive.spec.js
@@ -107,6 +107,38 @@ describe('Component keep-alive', () => {
     }).then(done)
   })
 
+  // #4237
+  it('should update latest props/listners for a re-activated component', done => {
+    const one = {
+      props: ['prop'],
+      template: `<div>one {{ prop }}</div>`
+    }
+    const two = {
+      props: ['prop'],
+      template: `<div>two {{ prop }}</div>`
+    }
+    const vm = new Vue({
+      data: { view: 'one', n: 1 },
+      template: `
+        <div>
+          <keep-alive>
+            <component :is="view" :prop="n"></component>
+          </keep-alive>
+        </div>
+      `,
+      components: { one, two }
+    }).$mount()
+
+    expect(vm.$el.textContent).toBe('one 1')
+    vm.n++
+    waitForUpdate(() => {
+      expect(vm.$el.textContent).toBe('one 2')
+      vm.view = 'two'
+    }).then(() => {
+      expect(vm.$el.textContent).toBe('two 2')
+    }).then(done)
+  })
+
   if (!isIE9) {
     it('with transition-mode out-in', done => {
       let next

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,9 @@ function init (vnode: VNodeWithData, hydrating: boolean) {`
`154`	`154`	`if (!vnode.child \|\| vnode.child._isDestroyed) {`
`155`	`155`	`const child = vnode.child = createComponentInstanceForVnode(vnode, activeInstance)`
`156`	`156`	`child.$mount(hydrating ? vnode.elm : undefined, hydrating)`
	`157`	`+ } else if (vnode.data.keepAlive) {`
	`158`	`+ // kept-alive components, treat as a patch`
	`159`	`+ prepatch(vnode, vnode)`
`157`	`160`	`}`
`158`	`161`	`}`
`159`	`162`