stablize subscribers in dep notify loop

yyx990803 · yyx990803 · commit bcb5e5145390 · 2015-02-19T11:59:59.000-08:00
diff --git a/src/observer/dep.js b/src/observer/dep.js
@@ -1,4 +1,5 @@
 var uid = 0
+var _ = require('../util')
 
 /**
  * A dep is an observable that can have multiple
@@ -42,7 +43,9 @@ p.removeSub = function (sub) {
  */
 
 p.notify = function () {
-  for (var i = 0, subs = this.subs; i < subs.length; i++) {
+  // stablize the subscriber list first
+  var subs = _.toArray(this.subs)
+  for (var i = 0, l = subs.length; i < l; i++) {
     subs[i].update()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`var uid = 0`
	`2`	`+var _ = require('../util')`
`2`	`3`
`3`	`4`	`/**`
`4`	`5`	`* A dep is an observable that can have multiple`
`@@ -42,7 +43,9 @@ p.removeSub = function (sub) {`
`42`	`43`	`*/`
`43`	`44`
`44`	`45`	`p.notify = function () {`
`45`		`- for (var i = 0, subs = this.subs; i < subs.length; i++) {`
	`46`	`+ // stablize the subscriber list first`
	`47`	`+ var subs = _.toArray(this.subs)`
	`48`	`+ for (var i = 0, l = subs.length; i < l; i++) {`
`46`	`49`	`subs[i].update()`
`47`	`50`	`}`
`48`	`51`	`}`