refactor patch createElm function, fix component hook merging

yyx990803 · yyx990803 · commit de7764a38573 · 2016-11-30T14:21:01.000-05:00
diff --git a/src/core/vdom/create-component.js b/src/core/vdom/create-component.js
@@ -172,7 +172,6 @@ function init (
     // kept-alive components, treat as a patch
     const mountedNode: any = vnode // work around flow
     prepatch(mountedNode, mountedNode)
-    return true // let the patcher know this is a reactivated component
   }
 }
 
@@ -318,11 +317,9 @@ function mergeHooks (data: VNodeData) {
   }
 }
 
-function mergeHook (a: Function, b: Function): Function {
-  // since all hooks have at most two args, use fixed args
-  // to avoid having to use fn.apply().
-  return (_, __) => {
-    a(_, __)
-    b(_, __)
+function mergeHook (one: Function, two: Function): Function {
+  return function (a, b, c, d) {
+    one(a, b, c, d)
+    two(a, b, c, d)
   }
 }
diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js
@@ -86,27 +86,12 @@ export function createPatchFunction (backend) {
 
   let inPre = 0
   function createElm (vnode, insertedVnodeQueue, parentElm, refElm, nested) {
-    let i, isReactivated
-    const data = vnode.data
-    vnode.isRootInsert = !nested
-    if (isDef(data)) {
-      if (isDef(i = data.hook) && isDef(i = i.init)) {
-        isReactivated = i(vnode, false /* hydrating */, parentElm, refElm)
-      }
-      // after calling the init hook, if the vnode is a child component
-      // it should've created a child instance and mounted it. the child
-      // component also has set the placeholder vnode's elm.
-      // in that case we can just return the element and be done.
-      if (isDef(i = vnode.child)) {
-        initComponent(vnode, insertedVnodeQueue)
-        if (isReactivated) {
-          // unlike a newly created component,
-          // a reactivated keep-alive component doesn't insert itself
-          insert(parentElm, vnode.child.$el, refElm)
-        }
-        return
-      }
+    vnode.isRootInsert = !nested // for transition enter check
+    if (createComponent(vnode, insertedVnodeQueue, parentElm, refElm)) {
+      return
     }
+
+    const data = vnode.data
     const children = vnode.children
     const tag = vnode.tag
     if (isDef(tag)) {
@@ -172,6 +157,29 @@ export function createPatchFunction (backend) {
     }
   }
 
+  function createComponent (vnode, insertedVnodeQueue, parentElm, refElm) {
+    let i = vnode.data
+    if (isDef(i)) {
+      const isReactivated = isDef(vnode.child) && i.keepAlive
+      if (isDef(i = i.hook) && isDef(i = i.init)) {
+        i(vnode, false /* hydrating */, parentElm, refElm)
+      }
+      // after calling the init hook, if the vnode is a child component
+      // it should've created a child instance and mounted it. the child
+      // component also has set the placeholder vnode's elm.
+      // in that case we can just return the element and be done.
+      if (isDef(vnode.child)) {
+        initComponent(vnode, insertedVnodeQueue)
+        if (isReactivated) {
+          // unlike a newly created component,
+          // a reactivated keep-alive component doesn't insert itself
+          insert(parentElm, vnode.elm, refElm)
+        }
+        return true
+      }
+    }
+  }
+
   function insert (parent, elm, ref) {
     if (parent) {
       nodeOps.insertBefore(parent, elm, ref)
diff --git a/test/unit/modules/vdom/create-component.spec.js b/test/unit/modules/vdom/create-component.spec.js
@@ -40,7 +40,7 @@ describe('create-component', () => {
     expect(vnode.context).toEqual(vm)
 
     vnode.data.hook.init(vnode)
-    expect(init).toHaveBeenCalledWith(vnode, undefined)
+    expect(init.calls.argsFor(0)[0]).toBe(vnode)
   })
 
   it('create a component when resolved with async loading', done => {

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,6 @@ function init (`
`172`	`172`	`// kept-alive components, treat as a patch`
`173`	`173`	`const mountedNode: any = vnode // work around flow`
`174`	`174`	`prepatch(mountedNode, mountedNode)`
`175`		`- return true // let the patcher know this is a reactivated component`
`176`	`175`	`}`
`177`	`176`	`}`
`178`	`177`
`@@ -318,11 +317,9 @@ function mergeHooks (data: VNodeData) {`
`318`	`317`	`}`
`319`	`318`	`}`
`320`	`319`
`321`		`-function mergeHook (a: Function, b: Function): Function {`
`322`		`- // since all hooks have at most two args, use fixed args`
`323`		`- // to avoid having to use fn.apply().`
`324`		`- return (_, __) => {`
`325`		`- a(_, __)`
`326`		`- b(_, __)`
	`320`	`+function mergeHook (one: Function, two: Function): Function {`
	`321`	`+ return function (a, b, c, d) {`
	`322`	`+ one(a, b, c, d)`
	`323`	`+ two(a, b, c, d)`
`327`	`324`	`}`
`328`	`325`	`}`