avoid resetting innerHTML/textContent if value is the same (fix vuejs#4247)

yyx990803 · yyx990803 · commit e4fd6327906a · 2016-11-18T11:56:56.000-05:00
diff --git a/src/platforms/web/runtime/modules/dom-props.js b/src/platforms/web/runtime/modules/dom-props.js
@@ -21,13 +21,14 @@ function updateDOMProps (oldVnode: VNodeWithData, vnode: VNodeWithData) {
     }
   }
   for (key in props) {
+    cur = props[key]
     // ignore children if the node has textContent or innerHTML,
     // as these will throw away existing DOM nodes and cause removal errors
     // on subsequent patches (#3360)
-    if ((key === 'textContent' || key === 'innerHTML') && vnode.children) {
-      vnode.children.length = 0
+    if (key === 'textContent' || key === 'innerHTML') {
+      if (vnode.children) vnode.children.length = 0
+      if (cur === oldProps[key]) continue
     }
-    cur = props[key]
     if (key === 'value') {
       // store value as _value as well since
       // non-string values will be stringified

Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,14 @@ function updateDOMProps (oldVnode: VNodeWithData, vnode: VNodeWithData) {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`	`for (key in props) {`
	`24`	`+ cur = props[key]`
`24`	`25`	`// ignore children if the node has textContent or innerHTML,`
`25`	`26`	`// as these will throw away existing DOM nodes and cause removal errors`
`26`	`27`	`// on subsequent patches (#3360)`
`27`		`- if ((key === 'textContent' \|\| key === 'innerHTML') && vnode.children) {`
`28`		`- vnode.children.length = 0`
	`28`	`+ if (key === 'textContent' \|\| key === 'innerHTML') {`
	`29`	`+ if (vnode.children) vnode.children.length = 0`
	`30`	`+ if (cur === oldProps[key]) continue`
`29`	`31`	`}`
`30`		`- cur = props[key]`
`31`	`32`	`if (key === 'value') {`
`32`	`33`	`// store value as _value as well since`
`33`	`34`	`// non-string values will be stringified`