Skip to content

Commit 733bda4

Browse files
authored
Let "module" version not be ES6, just ESM. (dexie#462)
* Let "module" version not be ES6, just ESM. Best practice seems to be not to deliver ES6 modules but ESM modules (just ES module syntax but not other non-ES5 code). Resolves dexie#460.
1 parent 6caf09b commit 733bda4

File tree

9 files changed

+29
-69
lines changed

9 files changed

+29
-69
lines changed

addons/Dexie.Observable/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"version": "1.0.0-beta.2",
44
"description": "Addon to Dexie that makes it possible to observe database changes no matter if they occur on other db instance or other window.",
55
"main": "dist/dexie-observable.js",
6-
"module": "src/Dexie.Observable.js",
7-
"jsnext:main": "src/Dexie.Observable.js",
6+
"module": "dist/dexie-observable.jsm",
7+
"jsnext:main": "dist/dexie-observable.jsm",
88
"typings": "dist/dexie-observable.d.ts",
99
"jspm": {
1010
"format": "cjs",

addons/Dexie.Observable/tools/build-configs/rollup.config.es6.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

addons/Dexie.Observable/tools/build-configs/rollup.config.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ const version = require(path.resolve(__dirname, '../../package.json')).version;
66

77
export default {
88
entry: 'tools/tmp/es5/src/Dexie.Observable.js',
9-
dest: 'dist/dexie-observable.js',
10-
format: 'umd',
9+
targets: [{
10+
dest: 'dist/dexie-observable.js',
11+
format: 'umd',
12+
},{
13+
dest: 'dist/dexie-observable.es.js',
14+
format: 'es'
15+
}],
1116
sourceMap: true,
1217
banner: readFileSync(path.resolve(__dirname, 'banner.txt'))+""
1318
.replace(/{version}/g, version)

addons/Dexie.Syncable/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
"version": "1.0.0-beta.2",
44
"description": "Addon to Dexie that makes it possible to sync indexeDB with remote databases.",
55
"main": "dist/dexie-syncable.js",
6-
"jsnext:main": "src/Dexie.Syncable.js",
6+
"module": "dist/dexie-syncable.jsm",
7+
"jsnext:main": "dist/dexie-syncable.jsm",
8+
"typings": "dist/dexie-syncable.d.ts",
79
"jspm": {
810
"format": "cjs",
911
"ignore": [

addons/Dexie.Syncable/tools/build-configs/rollup.config.es6.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

addons/Dexie.Syncable/tools/build-configs/rollup.config.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ const version = require(path.resolve(__dirname, '../../package.json')).version;
66

77
export default {
88
entry: 'tools/tmp/es5/addons/Dexie.Syncable/src/Dexie.Syncable.js',
9-
dest: 'dist/dexie-syncable.js',
10-
format: 'umd',
9+
targets: [{
10+
dest: 'dist/dexie-syncable.js',
11+
format: 'umd',
12+
},{
13+
dest: 'dist/dexie-syncable.es.js',
14+
format: 'es'
15+
}],
1116
sourceMap: true,
1217
banner: readFileSync(path.resolve(__dirname, 'banner.txt'))+""
1318
.replace(/{version}/g, version)

package.json

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"version": "2.0.0-beta.9",
44
"description": "A Minimalistic Wrapper for IndexedDB",
55
"main": "dist/dexie.js",
6-
"module": "dist/dexie.es6.js",
7-
"jsnext:main": "dist/dexie.es6.js",
6+
"module": "dist/dexie.jsm",
7+
"jsnext:main": "dist/dexie.jsm",
88
"typings": "dist/dexie.d.ts",
99
"jspm": {
1010
"format": "cjs",
@@ -53,14 +53,9 @@
5353
"node tools/replaceVersionAndDate.js dist/dexie.js",
5454
"eslint src"
5555
],
56-
"dexie-es6": [
57-
"tsc --allowJs -t es2015 -m es2015 --outDir tools/tmp/es6/src/ --sourceMap src/Dexie.js [--watch 'Compilation complete.']",
58-
"rollup -c tools/build-configs/rollup.config.es6.js",
59-
"node tools/replaceVersionAndDate.js dist/dexie.es6.js"
60-
],
6156
"release": [
6257
"# Build ES5 umd module as well as the es6 module.",
63-
"just-build dexie dexie-es6",
58+
"just-build dexie",
6459
"# Copy Dexie.d.ts to dist and replace version in it",
6560
"node -e \"fs.writeFileSync('dist/dexie.d.ts', fs.readFileSync('src/Dexie.d.ts'))\"",
6661
"node tools/replaceVersionAndDate.js dist/dexie.d.ts",

tools/build-configs/rollup.config.es6.js

Lines changed: 0 additions & 16 deletions
This file was deleted.

tools/build-configs/rollup.config.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ const version = require(path.resolve(__dirname, '../../package.json')).version;
66

77
export default {
88
entry: 'tools/tmp/es5/src/Dexie.js',
9-
dest: 'dist/dexie.js',
10-
format: 'umd',
9+
targets: [{
10+
dest: 'dist/dexie.js',
11+
format: 'umd',
12+
},{
13+
dest: 'dist/dexie.es.js',
14+
format: 'es'
15+
}],
1116
sourceMap: true,
1217
banner: readFileSync(path.resolve(__dirname, 'banner.txt'))+""
1318
.replace(/{version}/g, version)

0 commit comments

Comments
 (0)