Skip to content

Commit 241cdca

Browse files
committed
Ensure 'setPosition' respects scrolling direction
1 parent 0a5f0a5 commit 241cdca

File tree

4 files changed

+107
-4
lines changed

4 files changed

+107
-4
lines changed

jquery.stellar.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
},
6161
transform: {
6262
setPosition: function($elem, left, startingLeft, top, startingTop) {
63-
$elem[0].style[transform] = 'translate3d(' + ((left - startingLeft) || 0) + 'px, ' + ((top - startingTop) || 0) + 'px, 0)';
63+
$elem[0].style[transform] = 'translate3d(' + (left - startingLeft) + 'px, ' + (top - startingTop) + 'px, 0)';
6464
}
6565
}
6666
},
@@ -540,10 +540,17 @@
540540
if (this.options.horizontalScrolling) {
541541
newPositionLeft = (scrollLeft + particle.horizontalOffset + this.viewportOffsetLeft + particle.startingPositionLeft - particle.startingOffsetLeft + particle.parentOffsetLeft) * -(particle.stellarRatio + fixedRatioOffset - 1) + particle.startingPositionLeft;
542542
newOffsetLeft = newPositionLeft - particle.startingPositionLeft + particle.startingOffsetLeft;
543+
} else {
544+
newPositionLeft = particle.startingPositionLeft;
545+
newOffsetLeft = particle.startingOffsetLeft;
543546
}
547+
544548
if (this.options.verticalScrolling) {
545549
newPositionTop = (scrollTop + particle.verticalOffset + this.viewportOffsetTop + particle.startingPositionTop - particle.startingOffsetTop + particle.parentOffsetTop) * -(particle.stellarRatio + fixedRatioOffset - 1) + particle.startingPositionTop;
546550
newOffsetTop = newPositionTop - particle.startingPositionTop + particle.startingOffsetTop;
551+
} else {
552+
newPositionTop = particle.startingPositionTop;
553+
newOffsetTop = particle.startingOffsetTop;
547554
}
548555

549556
//Check visibility

0 commit comments

Comments
 (0)