make specs run under jruby

fkchang · ajjahn · commit cfb590595410 · 2015-12-10T18:04:44.000-05:00
diff --git a/lib/reactive-ruby/server_rendering/contextual_renderer.rb b/lib/reactive-ruby/server_rendering/contextual_renderer.rb
@@ -1,5 +1,13 @@
 module ReactiveRuby
   module ServerRendering
+    def self.context_instance_var_name
+      if RUBY_PLATFORM == 'java'
+        '@rhino_context'
+      else
+        '@v8_context'
+      end
+    end
+
     class ContextualRenderer < React::ServerRendering::SprocketsRenderer
       def initialize(options = {})
         super(options)
@@ -24,10 +32,8 @@ def render(component_name, props, prerender_options)
       def v8_runtime?
         ExecJS.runtime.name == "(V8)" || ExecJS.runtime.name == "therubyrhino (Rhino)"
       end
-
       def v8_context
-        @v8_context ||= @context.instance_variable_get("@v8_context")
-        @v8_context ||= @context.instance_variable_get("@rhino_context")
+        @v8_context ||= @context.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name)
       end
     end
   end
diff --git a/reactive-ruby.gemspec b/reactive-ruby.gemspec
@@ -28,5 +28,12 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'timecop'
   s.add_development_dependency 'opal-rspec'
   s.add_development_dependency 'sinatra'
-  s.add_development_dependency 'sqlite3' # For Test Rails App
+
+  if RUBY_PLATFORM == 'java'
+    s.add_development_dependency 'jdbc-sqlite3'  # For Test Rails App
+    s.add_development_dependency 'activerecord-jdbcsqlite3-adapter' if RUBY_PLATFORM == 'java' # For Test Rails App
+    s.add_development_dependency 'therubyrhino'
+  else
+    s.add_development_dependency 'sqlite3' # For Test Rails App
+  end
 end
diff --git a/spec/reactive-ruby/component_loader_spec.rb b/spec/reactive-ruby/component_loader_spec.rb
@@ -10,7 +10,7 @@
 
   let(:js) { ::Rails.application.assets['components'].to_s }
   let(:context) { ExecJS.compile(GLOBAL_WRAPPER + js) }
-  let(:v8_context) { context.instance_variable_get(:@v8_context) }
+  let(:v8_context) { context.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name) }
 
   describe '.new' do
     it 'raises a meaningful exception when initialized without a context' do
diff --git a/spec/reactive-ruby/isomorphic_helpers_spec.rb b/spec/reactive-ruby/isomorphic_helpers_spec.rb
@@ -73,7 +73,7 @@ def test_context(files = nil)
       end
       js = "#{React::ServerRendering::ExecJSRenderer::GLOBAL_WRAPPER}#{js}"
       ctx = ExecJS.compile(js)
-      ctx = ctx.instance_variable_get("@v8_context")
+      ctx = ctx.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name)
     end
 
     def react_context
