Skip to content

Commit 4fa33e7

Browse files
authored
[Tests] Relax allowed delta in extended_stats aggregation (elastic#27171)
The order in which double values are added in java can give different results for the sum, so we need to allow a certain delta in the test assertions. The current value was still a bit too low, which manifested itself in occasional test failures.
1 parent 9c4d6c6 commit 4fa33e7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ protected void assertReduced(InternalExtendedStats reduced, List<InternalExtende
8282
assertEquals(expectedCount, reduced.getCount());
8383
// The order in which you add double values in java can give different results. The difference can
8484
// be larger for large sum values, so we make the delta in the assertion depend on the values magnitude
85-
assertEquals(expectedSum, reduced.getSum(), Math.abs(expectedSum) * 1e-12);
85+
assertEquals(expectedSum, reduced.getSum(), Math.abs(expectedSum) * 1e-11);
8686
assertEquals(expectedMin, reduced.getMin(), 0d);
8787
assertEquals(expectedMax, reduced.getMax(), 0d);
8888
// summing squared values, see reason for delta above

0 commit comments

Comments
 (0)