Skip to content

Commit 824f1b2

Browse files
authored
Merge pull request kubernetes#48904 from saad-ali/automated-cherry-pick-of-#48762-upstream-release-1.5
Automated cherry pick of kubernetes#48762 upstream release 1.5
2 parents 7d4ee55 + 30d30c5 commit 824f1b2

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

build/common.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,13 @@ function kube::build::short_hash() {
392392
# a workaround for bug https://github.com/docker/docker/issues/3968.
393393
function kube::build::destroy_container() {
394394
"${DOCKER[@]}" kill "$1" >/dev/null 2>&1 || true
395-
"${DOCKER[@]}" wait "$1" >/dev/null 2>&1 || true
395+
if [[ $("${DOCKER[@]}" version --format '{{.Server.Version}}') = 17.06.0* ]]; then
396+
# Workaround https://github.com/moby/moby/issues/33948.
397+
# TODO: remove when 17.06.0 is not relevant anymore
398+
DOCKER_API_VERSION=v1.29 "${DOCKER[@]}" wait "$1" >/dev/null 2>&1 || true
399+
else
400+
"${DOCKER[@]}" wait "$1" >/dev/null 2>&1 || true
401+
fi
396402
"${DOCKER[@]}" rm -f -v "$1" >/dev/null 2>&1 || true
397403
}
398404

0 commit comments

Comments
 (0)