[no-relnote] Refactor AddRuntime #1279
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17298873827Details
💛 - Coveralls |
This change refactors the AddRuntime function into GetDefaultRuntimeOptions and AddRuntimeWithOptions. This allows for a clearer distinction between SOURCE and DESTINATION configs which should facilitate switching to drop-in files. Signed-off-by: Evan Lezar <elezar@nvidia.com>
aec10b2 to
5d37aba
Compare
| "runtime_type": c.RuntimeType, | ||
| "runtime_root": "", | ||
| "runtime_engine": "", | ||
| "privileged_without_host_devices": false, |
There was a problem hiding this comment.
I wonder if, on this fallback, we should add the SystemdCgroup = true|false based on a function that looks if the system is running systemd.
There was a problem hiding this comment.
The intent of this change is not to add additional behaviour. It is a refactor.
| } | ||
|
|
||
| config = *c.Tree | ||
| // Note: This is deprecated in containerd 1.4.0 and will be removed in 1.5.0 |
There was a problem hiding this comment.
Should we edit the note, now that 1.5.0 is released? and add a warning log.
There was a problem hiding this comment.
The intent of this change is not to add additional behaviour. It is a refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the AddRuntime function into GetDefaultRuntimeOptions and AddRuntimeWithOptions. This allows for a clearer distinction between SOURCE and DESTINATION configs which should facilitate switching to drop-in files.