Skip to content

Image disposal removes ImageSource content event when directly passed to the component. #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
boutier opened this issue Sep 12, 2024 · 2 comments
Open
3 tasks done

Image disposal removes ImageSource content event when directly passed to the component. #10625

boutier opened this issue Sep 12, 2024 · 2 comments
Labels
bug

Comments

@boutier
Copy link

boutier commented Sep 12, 2024

Issue Description

On iOS, I have an ImageSource that I want to pass to some Image components:

<Image *ngIf="cond" [src]="myImageSource"></Image>
<Image *ngIf="otherCond" [src]="myImageSource"></Image>

But when Image is disposed, it clears the content of the provided ImageSource (this.imageSource.ios = null; ), which makes it not reusable!

NativeScript/packages/core/ui/image/index.ios.ts

Lines 29 to 41 in 0506012

public disposeImageSource() {
if (this.nativeViewProtected?.image === this.imageSource?.ios) {
this.nativeViewProtected.image = null;
}
if (this.imageSource?.ios) {
this.imageSource.ios = null;
}
this.imageSource = null;
queueGC();
}

Note that when src is an ImageSource, the _createImageSourceFromSrc function does not create but just use the provided ImageSource

NativeScript/packages/core/ui/image/image-common.ts

Lines 124 to 127 in 0506012

} else if (value instanceof ImageSource) {
// Support binding the imageSource trough the src property
this.imageSource = value;
this.isLoading = false;

Reproduction

No response

Relevant log output (if applicable)

No response

Environment

No response

Please accept these terms
@boutier boutier added the bug-pending-triage Reported bug, pending triage to confirm. label Sep 12, 2024
@CatchABus
Copy link
Contributor

Interesting. Does android behave as expected?

@CatchABus CatchABus mentioned this issue Nov 23, 2024
Merged
5 tasks
@CatchABus CatchABus added bug and removed bug-pending-triage Reported bug, pending triage to confirm. labels Nov 23, 2024
@boutier
Copy link
Author

boutier commented Dec 4, 2024

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boutier @CatchABus