fix: change #aarrggbb to #rrggbbaa #8519
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
|
Yep, a lot of UI tests are failing. You can review them here - https://s3.amazonaws.com/ns-test-reports/index.html?prefix=reports/tns-modules/hex_colors/3942 |
|
@vtrifonov thanks will fix them. Nice report interface !!!! |
This little improvement should make things a bit faster by not using regexp. though we dont reject #re0000 for example. I will give a wrong color. Before it was simply showing no color. Not a big difference for a speed improvement
|
@vtrifonov i fixed the issues and all the test are passing here. |
|
@farfromrefug thanks for this excellent contribution - I've long wanted this as well as much more intuitive - Given it's a breaking change we'll put this on the 7.0 release plan 👍 |
|
@farfromrefug let's work together to get these changes into master - you may can close and reopen with target to master as would be nice to get this in {N} 7.0 |
8753605 to
86395da
Compare
d4ced42 to
53488b5
Compare
original pr credit to @farfromrefug #8519
|
Closing this since I reimplemented on our 8.0 cleanup branch here: |
original pr credit to @farfromrefug #8519 BREAKING CHANGE Long standing inconsistency with color handling here. BEFORE: ``` // #aarrggbb const color = new Color('#ff00ff00'); Label { background-color: #ff00ff00; } ``` AFTER: ``` // #rrggbbaa const color = new Color('#00ff00ff'); Label { background-color: #00ff00ff; } ```
original pr credit to @farfromrefug #8519 BREAKING CHANGE Long standing inconsistency with color handling here. BEFORE: ``` // #aarrggbb const color = new Color('#ff00ff00'); Label { background-color: #ff00ff00; } ``` AFTER: ``` // #rrggbbaa const color = new Color('#00ff00ff'); Label { background-color: #00ff00ff; } ```
original pr credit to @farfromrefug #8519 BREAKING CHANGE Long standing inconsistency with color handling here. BEFORE: ``` // #aarrggbb const color = new Color('#ff00ff00'); Label { background-color: #ff00ff00; } ``` AFTER: ``` // #rrggbbaa const color = new Color('#00ff00ff'); Label { background-color: #00ff00ff; } ```
original pr credit to @farfromrefug #8519 BREAKING CHANGE Long standing inconsistency with color handling here. BEFORE: ``` // #aarrggbb const color = new Color('#ff00ff00'); Label { background-color: #ff00ff00; } ``` AFTER: ``` // #rrggbbaa const color = new Color('#00ff00ff'); Label { background-color: #00ff00ff; } ```
original pr credit to @farfromrefug #8519 BREAKING CHANGE Long standing inconsistency with color handling here. BEFORE: ``` // #aarrggbb const color = new Color('#ff00ff00'); Label { background-color: #ff00ff00; } ``` AFTER: ``` // #rrggbbaa const color = new Color('#00ff00ff'); Label { background-color: #00ff00ff; } ```
This makes {N} support the web standard ##rrggbbaa format
See #8517
Now are there some tests to update?