fix: missing context keys do not throw PHP warning (GoogleCloudPlatform#43)

bshaffer · web-flow · commit 6ef24f86c5a8 · 2020-09-01T07:52:30.000-07:00
diff --git a/src/Context.php b/src/Context.php
@@ -37,7 +37,7 @@ public static function fromArray(array $arr)
         $argKeys = ['eventId', 'timestamp', 'eventType', 'resource'];
         $args = [];
         foreach ($argKeys as $key) {
-            $args[] = $arr[$key];
+            $args[] = $arr[$key] ?? null;
         }
 
         return new static(...$args);
diff --git a/tests/ContextTest.php b/tests/ContextTest.php
@@ -38,4 +38,13 @@ public function testFromArray()
         $this->assertEquals('ghi', $context->eventType);
         $this->assertEquals('jkl', $context->resource);
     }
+
+    public function testFromEmptyArray()
+    {
+        $context = Context::fromArray([]);
+        $this->assertEquals(null, $context->eventId);
+        $this->assertEquals(null, $context->timestamp);
+        $this->assertEquals(null, $context->eventType);
+        $this->assertEquals(null, $context->resource);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public static function fromArray(array $arr)`
`37`	`37`	`$argKeys = ['eventId', 'timestamp', 'eventType', 'resource'];`
`38`	`38`	`$args = [];`
`39`	`39`	`foreach ($argKeys as $key) {`
`40`		`- $args[] = $arr[$key];`
	`40`	`+ $args[] = $arr[$key] ?? null;`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`return new static(...$args);`
Original file line number	Diff line number	Diff line change
`@@ -38,4 +38,13 @@ public function testFromArray()`
`38`	`38`	`$this->assertEquals('ghi', $context->eventType);`
`39`	`39`	`$this->assertEquals('jkl', $context->resource);`
`40`	`40`	`}`
	`41`	`+`
	`42`	`+ public function testFromEmptyArray()`
	`43`	`+ {`
	`44`	`+ $context = Context::fromArray([]);`
	`45`	`+ $this->assertEquals(null, $context->eventId);`
	`46`	`+ $this->assertEquals(null, $context->timestamp);`
	`47`	`+ $this->assertEquals(null, $context->eventType);`
	`48`	`+ $this->assertEquals(null, $context->resource);`
	`49`	`+ }`
`41`	`50`	`}`