Skip to content

Commit 449ce04

Browse files
committed
workflow enable trying to solve
1 parent 47cb052 commit 449ce04

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

.github/workflows/firebase-hosting-merge.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@v2
14-
- uses: FirebaseExtended/action-hosting-deploy@v2
14+
- run: npm ci && npm run build
15+
- uses: FirebaseExtended/action-hosting-deploy@v0
1516
with:
1617
repoToken: '${{ secrets.GITHUB_TOKEN }}'
1718
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_PORTFOLIO_4E6E3 }}'

.github/workflows/firebase-hosting-pull-request.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ jobs:
88
runs-on: ubuntu-latest
99
steps:
1010
- uses: actions/checkout@v2
11-
- uses: FirebaseExtended/action-hosting-deploy@v2
11+
- run: npm ci && npm run build
12+
- uses: FirebaseExtended/action-hosting-deploy@v0
1213
with:
1314
repoToken: '${{ secrets.GITHUB_TOKEN }}'
1415
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_PORTFOLIO_4E6E3 }}'

v2/public/index.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -552,15 +552,15 @@ <h1 class="text-center section-heading">
552552

553553
<!-- end here -->
554554

555-
<!-- The core Firebase JS SDK is always required and must be listed first -->
556-
<script src="/__/firebase/8.10.0/firebase-app.js"></script>
555+
<!-- The core Firebase JS SDK is always required and must be listed first -->
556+
<script src="/__/firebase/8.10.0/firebase-app.js"></script>
557557

558-
<!-- TODO: Add SDKs for Firebase products that you want to use
559-
https://firebase.google.com/docs/web/setup#available-libraries -->
560-
<script src="/__/firebase/8.10.0/firebase-analytics.js"></script>
558+
<!-- TODO: Add SDKs for Firebase products that you want to use
559+
https://firebase.google.com/docs/web/setup#available-libraries -->
560+
<script src="/__/firebase/8.10.0/firebase-analytics.js"></script>
561561

562-
<!-- Initialize Firebase -->
563-
<script src="/__/firebase/init.js"></script>
562+
<!-- Initialize Firebase -->
563+
<script src="/__/firebase/init.js"></script>
564564

565565

566566
</body>

0 commit comments

Comments
 (0)