Skip to content

Commit 1369d54

Browse files
BrammmBrammm
committed
Made $map protected and moved it to construct.
By making $map protected and moving it to the construct, you can simply extend the BasicPermissionMap class if you want to simply add some extra permissions. In it's current form, you have to copy/paste the entire array AND the getMasks and contains functions. 
1 parent 83e078a commit 1369d54

File tree

1 file changed

+56
-51
lines changed

1 file changed

+56
-51
lines changed

‎src/Symfony/Component/Security/Acl/Permission/BasicPermissionMap.php

Lines changed: 56 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -28,58 +28,63 @@ class BasicPermissionMap implements PermissionMapInterface
2828
const PERMISSION_MASTER = 'MASTER';
2929
const PERMISSION_OWNER = 'OWNER';
3030

31-
private $map = array(
32-
self::PERMISSION_VIEW => array(
33-
MaskBuilder::MASK_VIEW,
34-
MaskBuilder::MASK_EDIT,
35-
MaskBuilder::MASK_OPERATOR,
36-
MaskBuilder::MASK_MASTER,
37-
MaskBuilder::MASK_OWNER,
38-
),
31+
protected $map;
3932

40-
self::PERMISSION_EDIT => array(
41-
MaskBuilder::MASK_EDIT,
42-
MaskBuilder::MASK_OPERATOR,
43-
MaskBuilder::MASK_MASTER,
44-
MaskBuilder::MASK_OWNER,
45-
),
46-
47-
self::PERMISSION_CREATE => array(
48-
MaskBuilder::MASK_CREATE,
49-
MaskBuilder::MASK_OPERATOR,
50-
MaskBuilder::MASK_MASTER,
51-
MaskBuilder::MASK_OWNER,
52-
),
53-
54-
self::PERMISSION_DELETE => array(
55-
MaskBuilder::MASK_DELETE,
56-
MaskBuilder::MASK_OPERATOR,
57-
MaskBuilder::MASK_MASTER,
58-
MaskBuilder::MASK_OWNER,
59-
),
60-
61-
self::PERMISSION_UNDELETE => array(
62-
MaskBuilder::MASK_UNDELETE,
63-
MaskBuilder::MASK_OPERATOR,
64-
MaskBuilder::MASK_MASTER,
65-
MaskBuilder::MASK_OWNER,
66-
),
67-
68-
self::PERMISSION_OPERATOR => array(
69-
MaskBuilder::MASK_OPERATOR,
70-
MaskBuilder::MASK_MASTER,
71-
MaskBuilder::MASK_OWNER,
72-
),
73-
74-
self::PERMISSION_MASTER => array(
75-
MaskBuilder::MASK_MASTER,
76-
MaskBuilder::MASK_OWNER,
77-
),
78-
79-
self::PERMISSION_OWNER => array(
80-
MaskBuilder::MASK_OWNER,
81-
),
82-
);
33+
public function __construct()
34+
{
35+
$this->map = array(
36+
self::PERMISSION_VIEW => array(
37+
MaskBuilder::MASK_VIEW,
38+
MaskBuilder::MASK_EDIT,
39+
MaskBuilder::MASK_OPERATOR,
40+
MaskBuilder::MASK_MASTER,
41+
MaskBuilder::MASK_OWNER,
42+
),
43+
44+
self::PERMISSION_EDIT => array(
45+
MaskBuilder::MASK_EDIT,
46+
MaskBuilder::MASK_OPERATOR,
47+
MaskBuilder::MASK_MASTER,
48+
MaskBuilder::MASK_OWNER,
49+
),
50+
51+
self::PERMISSION_CREATE => array(
52+
MaskBuilder::MASK_CREATE,
53+
MaskBuilder::MASK_OPERATOR,
54+
MaskBuilder::MASK_MASTER,
55+
MaskBuilder::MASK_OWNER,
56+
),
57+
58+
self::PERMISSION_DELETE => array(
59+
MaskBuilder::MASK_DELETE,
60+
MaskBuilder::MASK_OPERATOR,
61+
MaskBuilder::MASK_MASTER,
62+
MaskBuilder::MASK_OWNER,
63+
),
64+
65+
self::PERMISSION_UNDELETE => array(
66+
MaskBuilder::MASK_UNDELETE,
67+
MaskBuilder::MASK_OPERATOR,
68+
MaskBuilder::MASK_MASTER,
69+
MaskBuilder::MASK_OWNER,
70+
),
71+
72+
self::PERMISSION_OPERATOR => array(
73+
MaskBuilder::MASK_OPERATOR,
74+
MaskBuilder::MASK_MASTER,
75+
MaskBuilder::MASK_OWNER,
76+
),
77+
78+
self::PERMISSION_MASTER => array(
79+
MaskBuilder::MASK_MASTER,
80+
MaskBuilder::MASK_OWNER,
81+
),
82+
83+
self::PERMISSION_OWNER => array(
84+
MaskBuilder::MASK_OWNER,
85+
),
86+
);
87+
}
8388

8489
/**
8590
* {@inheritDoc}

0 commit comments

Comments
 (0)