Skip to content

Commit 5b51d88

Browse files
authored
Merge pull request #141 from PoslinskiNet/ember-3.5
Ember 3.6 upgrade
2 parents 206b8ad + 0ef82d1 commit 5b51d88

File tree

13 files changed

+2551
-1852
lines changed

13 files changed

+2551
-1852
lines changed

.eslintignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,13 @@
88

99
# dependencies
1010
/bower_components/
11+
/node_modules/
1112

1213
# misc
1314
/coverage/
15+
!.*
1416

1517
# ember-try
1618
/.node_modules.ember-try/
19+
/bower.json.ember-try
20+
/package.json.ember-try

.eslintrc.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ module.exports = {
2222
// node files
2323
{
2424
files: [
25+
'.eslintrc.js',
26+
'.template-lintrc.js',
2527
'ember-cli-build.js',
2628
'index.js',
2729
'testem.js',

.npmignore

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,30 @@
1-
/bower_components
1+
# compiled output
2+
/dist/
3+
/tmp/
4+
5+
# dependencies
6+
/bower_components/
7+
8+
# misc
9+
/.bowerrc
10+
/.editorconfig
11+
/.ember-cli
12+
/.eslintignore
13+
/.eslintrc.js
14+
/.gitignore
15+
/.template-lintrc.js
16+
/.travis.yml
17+
/.watchmanconfig
18+
/bower.json
219
/config/ember-try.js
3-
/dist
4-
/tests
5-
/tmp
6-
**/.gitkeep
7-
.bowerrc
8-
.editorconfig
9-
.ember-cli
10-
.eslintrc.js
11-
.gitignore
12-
.watchmanconfig
13-
.travis.yml
14-
bower.json
15-
ember-cli-build.js
16-
testem.js
17-
yarn.lock
20+
/CONTRIBUTING.md
21+
/ember-cli-build.js
22+
/testem.js
23+
/tests/
24+
/yarn.lock
25+
.gitkeep
1826

1927
# ember-try
20-
.node_modules.ember-try/
21-
bower.json.ember-try
22-
package.json.ember-try
28+
/.node_modules.ember-try/
29+
/bower.json.ember-try
30+
/package.json.ember-try

.template-lintrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: 'recommended'
5+
};

.travis.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@ env:
1919
global:
2020
# See https://git.io/vdao3 for details.
2121
- JOBS=1
22-
22+
23+
branches:
24+
only:
25+
- master
26+
# npm version tags
27+
- /^v\d+\.\d+\.\d+/
28+
2329
jobs:
2430
fail_fast: true
2531
allow_failures:
@@ -31,18 +37,19 @@ jobs:
3137
- stage: "Tests"
3238
name: "Tests"
3339
script:
40+
# - npm run lint:hbs
3441
- npm run lint:js
3542
- npm test
3643

3744
# we recommend new addons test the current and previous LTS
3845
# as well as latest stable release (bonus points to beta/canary)
3946
- stage: "Additional Tests"
40-
env: EMBER_TRY_SCENARIO=ember-lts-2.12
41-
- env: EMBER_TRY_SCENARIO=ember-lts-2.16
47+
env: EMBER_TRY_SCENARIO=ember-lts-2.16
4248
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
4349
- env: EMBER_TRY_SCENARIO=ember-release
4450
- env: EMBER_TRY_SCENARIO=ember-beta
4551
- env: EMBER_TRY_SCENARIO=ember-canary
52+
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
4653

4754
before_install:
4855
- npm config set spin false

CONTRIBUTING.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# How To Contribute
2+
3+
## Installation
4+
5+
* `git clone git@github.com:PoslinskiNet/ember-introjs.git`
6+
* `cd ember-introjs`
7+
* `npm install`
8+
9+
## Linting
10+
11+
* `npm run lint:hbs`
12+
* `npm run lint:js`
13+
* `npm run lint:js -- --fix`
14+
15+
## Running tests
16+
17+
* `ember test` – Runs the test suite on the current Ember version
18+
* `ember test --server` – Runs the test suite in "watch mode"
19+
* `ember try:each` – Runs the test suite against multiple Ember versions
20+
21+
## Running the dummy application
22+
23+
* `ember serve`
24+
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
25+
26+
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

README.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Installation
2020
### 1st option (recommended)
2121
#### Use `intro-js/step` component as a wrapper
2222

23-
```hbs
23+
```handlebars
2424
{{#intro-js/step step=1 intro="Step Component"}}
2525
<h1>Hello!</h1>
2626
{{/intro-js/step}}
@@ -197,19 +197,6 @@ To use them, first import them in your `tests/test-helper.js` file:
197197
import './helpers/ember-introjs';
198198
```
199199

200-
### Running tests
201-
202-
* `ember test` – Runs the test suite on the current Ember version
203-
* `ember test --server` – Runs the test suite in "watch mode"
204-
* `ember try:each` – Runs the test suite against multiple Ember versions
205-
206-
### Running the dummy application
207-
208-
* `ember serve`
209-
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
210-
211-
For more information on using ember-cli, visit [http://www.ember-cli.com/](http://www.ember-cli.com/).
212-
213200
## LICENSE
214201

215202
See the LICENSE file included in this repository.

config/ember-try.js

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,26 @@ module.exports = function() {
1010
]).then((urls) => {
1111
return {
1212
scenarios: [
13-
{
14-
name: 'ember-lts-2.12',
15-
npm: {
16-
devDependencies: {
17-
'ember-source': '~2.12.0'
18-
}
19-
}
20-
},
2113
{
2214
name: 'ember-lts-2.16',
15+
env: {
16+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
17+
},
2318
npm: {
2419
devDependencies: {
20+
'@ember/jquery': '^0.5.1',
2521
'ember-source': '~2.16.0'
2622
}
2723
}
2824
},
2925
{
3026
name: 'ember-lts-2.18',
27+
env: {
28+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
29+
},
3130
npm: {
3231
devDependencies: {
32+
'@ember/jquery': '^0.5.1',
3333
'ember-source': '~2.18.0'
3434
}
3535
}
@@ -59,9 +59,16 @@ module.exports = function() {
5959
}
6060
},
6161
{
62-
name: 'ember-default',
62+
name: 'ember-default-with-jquery',
63+
env: {
64+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
65+
'jquery-integration': true
66+
})
67+
},
6368
npm: {
64-
devDependencies: {}
69+
devDependencies: {
70+
'@ember/jquery': '^0.5.1'
71+
}
6572
}
6673
}
6774
]

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const Funnel = require('broccoli-funnel');
66
const mergeTrees = require('broccoli-merge-trees');
77

88
module.exports = {
9-
name: 'ember-introjs',
9+
name: require('./package').name,
1010

1111
included(app) {
1212
this._super.included(app);
@@ -31,5 +31,5 @@ module.exports = {
3131
});
3232

3333
return tree ? new mergeTrees([tree, introJsTree]) : introJsTree;
34-
},
35-
};
34+
}
35+
}

jsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"compilerOptions":{"target":"es6","experimentalDecorators":true},"exclude":["node_modules","bower_components","tmp","vendor",".git","dist"]}

0 commit comments

Comments
 (0)