fix(ui): clear client addons on PluginApi reset

Guillaume Chau · Guillaume Chau · commit 3eb511665d2b · 2018-06-21T15:20:47.000+02:00
diff --git a/packages/@vue/cli-ui/src/graphql-api/connectors/client-addons.js b/packages/@vue/cli-ui/src/graphql-api/connectors/client-addons.js
@@ -39,6 +39,12 @@ function remove (id, context) {
   if (index !== -1) addons.splice(index, 1)
 }
 
+function clear (context) {
+  for (const addon of addons) {
+    remove(addon.id, context)
+  }
+}
+
 function getUrl (addon, context) {
   return addon.url || `${baseUrl}/_addon/${addon.id}/index.js`
 }
@@ -64,5 +70,6 @@ module.exports = {
   remove,
   findOne,
   getUrl,
-  serve
+  serve,
+  clear
 }
diff --git a/packages/@vue/cli-ui/src/graphql-api/connectors/plugins.js b/packages/@vue/cli-ui/src/graphql-api/connectors/plugins.js
@@ -102,6 +102,7 @@ function resetPluginApi (context) {
   }
   sharedData.unWatchAll()
 
+  clientAddons.clear(context)
   suggestions.clear(context)
 
   pluginApi = new PluginApi({

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,12 @@ function remove (id, context) {`
`39`	`39`	`if (index !== -1) addons.splice(index, 1)`
`40`	`40`	`}`
`41`	`41`
	`42`	`+function clear (context) {`
	`43`	`+ for (const addon of addons) {`
	`44`	`+ remove(addon.id, context)`
	`45`	`+ }`
	`46`	`+}`
	`47`	`+`
`42`	`48`	`function getUrl (addon, context) {`
`43`	`49`	return addon.url \|\| `${baseUrl}/_addon/${addon.id}/index.js`
`44`	`50`	`}`
`@@ -64,5 +70,6 @@ module.exports = {`
`64`	`70`	`remove,`
`65`	`71`	`findOne,`
`66`	`72`	`getUrl,`
`67`		`- serve`
	`73`	`+ serve,`
	`74`	`+ clear`
`68`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ function resetPluginApi (context) {`
`102`	`102`	`}`
`103`	`103`	`sharedData.unWatchAll()`
`104`	`104`
	`105`	`+ clientAddons.clear(context)`
`105`	`106`	`suggestions.clear(context)`
`106`	`107`
`107`	`108`	`pluginApi = new PluginApi({`