fix: code polish

Guillaume Chau · Guillaume Chau · commit cbd33a4d3ac0 · 2018-05-30T11:25:16.000+02:00
diff --git a/packages/@vue/cli/lib/util/module.js b/packages/@vue/cli/lib/util/module.js
@@ -7,21 +7,21 @@ function resolveFallback (request, options) {
 
   const paths = []
 
-  for (var i = 0; i < options.paths.length; i++) {
+  for (let i = 0; i < options.paths.length; i++) {
     const path = options.paths[i]
     fakeParent.paths = Module._nodeModulePaths(path)
     const lookupPaths = Module._resolveLookupPaths(request, fakeParent, true)
 
     if (!paths.includes(path)) paths.push(path)
 
-    for (var j = 0; j < lookupPaths.length; j++) {
+    for (let j = 0; j < lookupPaths.length; j++) {
       if (!paths.includes(lookupPaths[j])) paths.push(lookupPaths[j])
     }
   }
 
-  var filename = Module._findPath(request, paths, isMain)
+  const filename = Module._findPath(request, paths, isMain)
   if (!filename) {
-    var err = new Error(`Cannot find module '${request}'`)
+    const err = new Error(`Cannot find module '${request}'`)
     err.code = 'MODULE_NOT_FOUND'
     throw err
   }
diff --git a/packages/@vue/cli/lib/util/nodeVersion.js b/packages/@vue/cli/lib/util/nodeVersion.js
@@ -1,5 +1,4 @@
 exports.minNode = function (major, minor = 0, patch = 0) {
-  const parts = process.versions.node.split('.').map(v => parseInt(v))
-  if (parts[0] >= major && parts[1] >= minor && parts[2] >= patch) return true
-  return false
+  const [M, m, p] = process.versions.node.split('.').map(v => parseInt(v))
+  return (M >= major && m >= minor && p >= patch)
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`exports.minNode = function (major, minor = 0, patch = 0) {`
`2`		`- const parts = process.versions.node.split('.').map(v => parseInt(v))`
`3`		`- if (parts[0] >= major && parts[1] >= minor && parts[2] >= patch) return true`
`4`		`- return false`
	`2`	`+ const [M, m, p] = process.versions.node.split('.').map(v => parseInt(v))`
	`3`	`+ return (M >= major && m >= minor && p >= patch)`
`5`	`4`	`}`