fix(unit-mocha): ensure correct mode for webpack config

yyx990803 · yyx990803 · commit e17f78c6c5ab · 2018-05-30T11:37:30.000-04:00
close vuejs#1389
diff --git a/packages/@vue/cli-service/lib/config/base.js b/packages/@vue/cli-service/lib/config/base.js
@@ -5,6 +5,7 @@ module.exports = (api, options) => {
     const inlineLimit = 10000
 
     webpackConfig
+      .mode('development')
       .context(api.service.context)
       .entry('app')
         .add('./src/main.js')
diff --git a/packages/@vue/cli-service/lib/config/dev.js b/packages/@vue/cli-service/lib/config/dev.js
@@ -1,9 +1,6 @@
 module.exports = (api, options) => {
   api.chainWebpack(webpackConfig => {
     if (process.env.NODE_ENV === 'development') {
-      webpackConfig
-        .mode('development')
-
       webpackConfig
         .devtool('cheap-module-eval-source-map')
         .output
@@ -13,10 +10,6 @@ module.exports = (api, options) => {
         .plugin('hmr')
           .use(require('webpack/lib/HotModuleReplacementPlugin'))
 
-      webpackConfig
-        .plugin('named-modules')
-          .use(require('webpack/lib/NamedModulesPlugin'))
-
       webpackConfig
         .plugin('no-emit-on-errors')
           .use(require('webpack/lib/NoEmitOnErrorsPlugin'))
diff --git a/packages/@vue/cli-service/webpack.config.js b/packages/@vue/cli-service/webpack.config.js
@@ -6,7 +6,7 @@ let service = process.VUE_CLI_SERVICE
 if (!service) {
   const Service = require('./lib/Service')
   service = new Service(process.env.VUE_CLI_CONTEXT || process.cwd())
-  service.init()
+  service.init(process.env.VUE_CLI_MODE || process.env.NODE_ENV)
 }
 
 module.exports = service.resolveWebpackConfig()

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ let service = process.VUE_CLI_SERVICE`
`6`	`6`	`if (!service) {`
`7`	`7`	`const Service = require('./lib/Service')`
`8`	`8`	`service = new Service(process.env.VUE_CLI_CONTEXT \|\| process.cwd())`
`9`		`- service.init()`
	`9`	`+ service.init(process.env.VUE_CLI_MODE \|\| process.env.NODE_ENV)`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`module.exports = service.resolveWebpackConfig()`