[extensions][wkb] Fix risk of undefined behavior when parsing a byte_order byte

CG-SD · web-flow · commit 35a02b7ee64b · 2020-11-21T02:53:39.000+01:00
* fixed risk of undefined behavior when parsing a byte_order byte tried to parse a spatialite WKB blob with this code but the byte_order byte was replaced by a '69' token : parsing this byte is successful but the value read is not part of the enum, the function returns true but the order parameter is left untouched. Calls to that function elsewhere in the code do not initialise the order parameter. see https://github.com/boostorg/geometry/blob/869e72fc01f2fce5ec3bcdfb91afab65ebd3ec6f/include/boost/geometry/extensions/multi/gis/io/wkb/detail/parser.hpp#L83 another option would be to return false in that case, but it didn't fit my need * Update parser.hpp typo fix
diff --git a/include/boost/geometry/extensions/gis/io/wkb/detail/parser.hpp b/include/boost/geometry/extensions/gis/io/wkb/detail/parser.hpp
@@ -116,6 +116,8 @@ struct byte_order_parser
             if (byte_order_type::unknown > value)
             {
                 order = byte_order_type::enum_t(value);
+            }else{
+                order = byte_order_type::unknown;
             }
             return true;
         }

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,8 @@ struct byte_order_parser`
`116`	`116`	`if (byte_order_type::unknown > value)`
`117`	`117`	`{`
`118`	`118`	`order = byte_order_type::enum_t(value);`
	`119`	`+ }else{`
	`120`	`+ order = byte_order_type::unknown;`
`119`	`121`	`}`
`120`	`122`	`return true;`
`121`	`123`	`}`