Skip to content

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Aug 12, 2025

Description

Updates to Java 21 requirement for 2.13 and updates Gradle to 9.0.0. Sets the gradle shadow plugin to the newly updated gradleup version of the original plugin.

Converts to JUnit 5.

Uses ClassGraph instead of Guava's deprecated ClassLoad.

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner August 12, 2025 12:42
@TheLimeGlass TheLimeGlass requested review from Pesekjak and TheMug06 and removed request for a team August 12, 2025 12:42
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Aug 12, 2025
@TheLimeGlass TheLimeGlass requested a review from a team as a code owner August 12, 2025 12:44
@TheLimeGlass TheLimeGlass requested review from UnderscoreTud and removed request for a team August 12, 2025 12:44
@TheLimeGlass TheLimeGlass marked this pull request as draft August 12, 2025 15:10
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Aug 12, 2025
Copy link
Contributor

@TheMug06 TheMug06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minecraft 1.20.4 (the lowest version for Skript 2.13) required Java 17+. Why are you switching to Java 21 only?

@TheLimeGlass
Copy link
Contributor Author

Minecraft 1.20.4 (the lowest version for Skript 2.13) required Java 17+. Why are you switching to Java 21 only?

It allows for Java 21? What are you meaning about 1.20.4

@TheLimeGlass
Copy link
Contributor Author

JUnit currently errors because Java 21 security is halting the way JUnit works. Needing to investigate.

Copy link
Contributor

@Absolutionism Absolutionism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows for Java 21? What are you meaning about 1.20.4

Skript 2.13 is raising the minimum supported version from 1.19.4 to 1.20.4, not 1.20.6.
Please revert the necessary changes to accommodate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants