code review change.js

baukh789 · baukh789 · commit a8eabf8833a4 · 2018-03-09T18:56:16.000+08:00
diff --git a/src/js/Cache.js b/src/js/Cache.js
@@ -11,6 +11,13 @@ import Checkbox from './Checkbox';
 import Order from './Order';
 import store from './Store';
 class Cache {
+	/**
+	 * 版本信息
+	 * @returns {*}
+     */
+	getVersion() {
+		return store.version;
+	}
 
 	/**
 	 * 获取当前行渲染时使用的数据
@@ -56,9 +63,10 @@ class Cache {
 	 * 获取完整的渲染时使用的数据
 	 * @param $table
 	 */
-	getTableData($table) {
-		return store.responseData[Base.getKey($table)] || {};
-	}
+	// TODO 该方法暂时无用
+	// getTableData($table) {
+	// 	return store.responseData[Base.getKey($table)] || {};
+	// }
 
 	/**
 	 * 删除用户记忆
diff --git a/src/js/GridManager.js b/src/js/GridManager.js
@@ -16,7 +16,6 @@ import Menu from './Menu';
 import Remind from './Remind';
 import Scroll from './Scroll';
 import Sort from './Sort';
-import store from './Store';
 import Hover from './Hover';
 export default class GridManager {
 	/**
@@ -27,7 +26,7 @@ export default class GridManager {
 	 */
 	static
 	get version() {
-		return store.version;
+		return Cache.getVersion();
 	}
 
 	/**
diff --git a/test/Cache_test.js b/test/Cache_test.js
@@ -26,6 +26,17 @@ describe('Cache 验证类的属性及方法总量', function() {
 	});
 });
 
+describe('Cache.getVersion()', function() {
+	it('基础验证', function(){
+		expect(Cache.getVersion).toBeDefined();
+		expect(Cache.getVersion.length).toBe(0);
+	});
+
+	it('验证返回值', function(){
+		expect(typeof(Cache.getVersion())).toBe('string');
+	});
+});
+
 describe('Cache.getRowData($table, target)', function() {
 	it('基础验证', function(){
 		expect(Cache.getRowData).toBeDefined();
@@ -40,13 +51,6 @@ describe('Cache.setRowData(gmName, key, value)', function() {
 	});
 });
 
-describe('Cache.getTableData($table)', function() {
-	it('基础验证', function(){
-		expect(Cache.getTableData).toBeDefined();
-		expect(Cache.getTableData.length).toBe(1);
-	});
-});
-
 describe('Cache.delUserMemory($table, cleanText)', function() {
 	it('基础验证', function(){
 		expect(Cache.delUserMemory).toBeDefined();
