Fix collection creation options if trying insert new document in non-existing collection

ivanignatiev · ivanignatiev · commit 9a7dfea5908a · 2019-03-17T11:00:18.000+01:00
diff --git a/lib/ArangoDBClient/DocumentHandler.php b/lib/ArangoDBClient/DocumentHandler.php
@@ -806,17 +806,20 @@ private function getRevision($document)
         return $revision;
     }
 
+
     /**
      * @param       $collection   mixed collection name or id
      * @param array $options      - optional, array of options
      *                            <p>Options are :
      *                            <li>'createCollection' - true to create the collection if it does not exist</li>
      *                            <li>'createCollectionType' - "document" or 2 for document collection</li>
      *                            <li>                         "edge" or 3 for edge collection</li>
+     *                            <li>'waitForSync'       - if set to true, then all removal operations will instantly be synchronised to disk / If this is not specified, then the collection's default sync behavior will be applied.</li>
      *                            </p>
      */
     protected function createCollectionIfOptions($collection, $options)
     {
+
         if (!array_key_exists(CollectionHandler::OPTION_CREATE_COLLECTION, $options)) {
             return;
         }
@@ -829,18 +832,25 @@ protected function createCollectionIfOptions($collection, $options)
 
         $collectionHandler = new CollectionHandler($this->getConnection());
 
+        $params = [];
+
         if (array_key_exists('createCollectionType', $options)) {
-            $options['type'] = $options['createCollectionType'];
-            unset($options['createCollectionType']);
+            $params['type'] = $options['createCollectionType'];
+        }
+
+        if (array_key_exists('waitForSync', $options)) {
+            $params['waitForSync'] = $options['waitForSync'];
         }
-        unset($options['createCollection']);
+
         try {
             // attempt to create the collection
-            $collectionHandler->create($collection, $options);
+            $collectionHandler->create($collection, $params);
         } catch (Exception $e) {
             // collection may have existed already
         }
     }
 }
 
+}
+
 class_alias(DocumentHandler::class, '\triagens\ArangoDb\DocumentHandler');
