Skip to content

Commit 7925c15

Browse files
committed
Merge branch 'develop'
Conflicts: README.md
2 parents dcce73b + 262ce8b commit 7925c15

File tree

4 files changed

+23
-13
lines changed

4 files changed

+23
-13
lines changed

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ All you need to do is:
1717
First, add gradle dependency with command:<br>
1818
```groovy
1919
dependencies {
20-
compile 'com.cleveroad:slidingtutorial:0.9.2'
20+
compile 'com.cleveroad:slidingtutorial:0.9.3'
2121
}
2222
```
2323

@@ -116,20 +116,21 @@ public class CustomPresentationPagerFragment extends PresentationPagerFragment {
116116
}
117117

118118
@Override
119-
protected boolean onSkipButtonClicked(View skipButton) {
120-
// your own behavior goes here
121-
// ...
122-
// return true to consume click event, false otherwise
123-
return true;
124-
}
119+
protected boolean onSkipButtonClicked() {
120+
// your own behavior goes here
121+
// ...
122+
// return true to consume click event, false otherwise
123+
return true;
124+
}
125125
}
126126
```
127127

128128
## Changelog
129129

130130
| Version | Changes |
131131
| --- | --- |
132-
| v.0.9.2 | Added onSkipButtonClciked method and SimplePagerFragment |
132+
| v.0.9.3 | Fixed issue with wrong page showed at startup if pages count not equals 3 |
133+
| v.0.9.2 | Added onSkipButtonClicked method and SimplePagerFragment |
133134
| v.0.9.1 | Added infinite scroll behavior |
134135
| v.0.9 | First public release |
135136

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
VERSION_NAME=0.9.2
2-
VERSION_CODE=3
1+
VERSION_NAME=0.9.3
2+
VERSION_CODE=4
33
GROUP=com.cleveroad
44

55
POM_DESCRIPTION=Sliding tutorial is simple library that help other developers easy create great tutotial

lib/src/main/java/com/cleveroad/slidingtutorial/PresentationPagerFragment.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ public void onViewCreated(View view, Bundle savedInstanceState) {
7474
super.onViewCreated(view, savedInstanceState);
7575
viewPager.setAdapter(new PresentationAdapter(getChildFragmentManager()));
7676
if (isInfiniteScrollEnabled()) {
77-
viewPager.setCurrentItem(Integer.MAX_VALUE / 2);
77+
int pos = Integer.MAX_VALUE / 2;
78+
pos -= pos % getPagesCount();
79+
viewPager.setCurrentItem(pos);
7880
}
7981
indicator.setViewPager(new ViewPagerWrapper(getContext(), viewPager), getPagesCount());
8082
viewPager.addOnPageChangeListener(this);
@@ -104,7 +106,7 @@ public void onPageScrolled(int position, float positionOffset, int positionOffse
104106
}
105107
int nextColorPosition = position + 1;
106108
if (nextColorPosition >= getPagesCount()) {
107-
nextColorPosition = 0;
109+
nextColorPosition %= getPagesCount();
108110
}
109111
if (position < (viewPager.getAdapter().getCount() - 1)) {
110112
viewPager.setBackgroundColor((Integer) argbEvaluator.evaluate(positionOffset, getPageColor(position), getPageColor(nextColorPosition)));

sample/src/main/java/com/cleveroad/slidingtutorial/sample/CustomPresentationPagerFragment.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ public class CustomPresentationPagerFragment extends SimplePagerFragment {
1313

1414
@Override
1515
protected int getPagesCount() {
16-
return 3;
16+
return 6;
1717
}
1818

1919
@Override
2020
protected PageFragment getPage(int position) {
21+
position %= 3;
2122
if (position == 0)
2223
return new FirstCustomPageFragment();
2324
if (position == 1)
@@ -36,6 +37,12 @@ protected int getPageColor(int position) {
3637
return ContextCompat.getColor(getContext(), android.R.color.holo_green_dark);
3738
if (position == 2)
3839
return ContextCompat.getColor(getContext(), android.R.color.holo_blue_dark);
40+
if (position == 3)
41+
return ContextCompat.getColor(getContext(), android.R.color.holo_red_dark);
42+
if (position == 4)
43+
return ContextCompat.getColor(getContext(), android.R.color.holo_purple);
44+
if (position == 5)
45+
return ContextCompat.getColor(getContext(), android.R.color.darker_gray);
3946
return Color.TRANSPARENT;
4047
}
4148

0 commit comments

Comments
 (0)