From ca488622600c39de6d80762fbad2d46c379133bf Mon Sep 17 00:00:00 2001 From: Raveendra Pujari Date: Tue, 3 Jun 2025 14:57:15 -0500 Subject: [PATCH 1/7] [#6258][BUG] Tests of Isomorphic --- .../thealgorithms/strings/IsomorphicTest.java | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 0dac47551868..42807900eab5 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -3,29 +3,29 @@ import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -import org.junit.jupiter.api.Test; - -public final class IsomorphicTest { - private IsomorphicTest() { - } +import java.util.stream.Stream; - @Test - public static void main(String[] args) { - String str1 = "abbbbaac"; - String str2 = "kffffkkd"; +import static org.junit.jupiter.api.Assertions.assertEquals; - String str3 = "xyxyxy"; - String str4 = "bnbnbn"; - - String str5 = "ghjknnmm"; - String str6 = "wertpopo"; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; - String str7 = "aaammmnnn"; - String str8 = "ggghhhbbj"; +public final class IsomorphicTest { - assertTrue(Isomorphic.checkStrings(str1, str2)); - assertTrue(Isomorphic.checkStrings(str3, str4)); - assertFalse(Isomorphic.checkStrings(str5, str6)); - assertFalse(Isomorphic.checkStrings(str7, str8)); + @ParameterizedTest + @MethodSource("isomorphicProvider") + public void testCheckStrings(String str1, String str2, boolean expected) { + assertEquals(expected, Isomorphic.checkStrings(str1, str2)); + } + + private static Stream isomorphicProvider() { + return Stream.of( + Arguments.of("abbbbaac", "kffffkkd", true), + Arguments.of("xyxyxy", "bnbnbn", true), + Arguments.of("ghjknnmm", "wertpopo", false), + Arguments.of("aaammmnnn", "ggghhhbbj", false) + ); } } From 07bfcc06a42e855e579c2efc5e84402a1e36dae7 Mon Sep 17 00:00:00 2001 From: Raveendra Pujari Date: Tue, 3 Jun 2025 15:10:35 -0500 Subject: [PATCH 2/7] with clang-format --- .../com/thealgorithms/strings/IsomorphicTest.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 42807900eab5..141cc245fc93 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -1,12 +1,10 @@ package com.thealgorithms.strings; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; import java.util.stream.Stream; - -import static org.junit.jupiter.api.Assertions.assertEquals; - import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; @@ -19,13 +17,8 @@ public final class IsomorphicTest { public void testCheckStrings(String str1, String str2, boolean expected) { assertEquals(expected, Isomorphic.checkStrings(str1, str2)); } - + private static Stream isomorphicProvider() { - return Stream.of( - Arguments.of("abbbbaac", "kffffkkd", true), - Arguments.of("xyxyxy", "bnbnbn", true), - Arguments.of("ghjknnmm", "wertpopo", false), - Arguments.of("aaammmnnn", "ggghhhbbj", false) - ); + return Stream.of(Arguments.of("abbbbaac", "kffffkkd", true), Arguments.of("xyxyxy", "bnbnbn", true), Arguments.of("ghjknnmm", "wertpopo", false), Arguments.of("aaammmnnn", "ggghhhbbj", false)); } } From f2d1f5645fa445b121d25e94d03c09c4c1e782a4 Mon Sep 17 00:00:00 2001 From: Raveendra Pujari Date: Tue, 3 Jun 2025 15:14:00 -0500 Subject: [PATCH 3/7] removed unused imports --- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 141cc245fc93..25e1c14e5d09 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -1,11 +1,8 @@ package com.thealgorithms.strings; import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertTrue; import java.util.stream.Stream; -import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; From e5bddf97103f719c60c18b4580105e20a82320af Mon Sep 17 00:00:00 2001 From: Raveendra Pujari Date: Tue, 3 Jun 2025 15:24:07 -0500 Subject: [PATCH 4/7] replaced boolean literals with Boolean.TRUE/FALSE in IsomorphicTest --- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 25e1c14e5d09..18f358d04e23 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -11,11 +11,11 @@ public final class IsomorphicTest { @ParameterizedTest @MethodSource("isomorphicProvider") - public void testCheckStrings(String str1, String str2, boolean expected) { + public void testCheckStrings(String str1, String str2, Boolean expected) { assertEquals(expected, Isomorphic.checkStrings(str1, str2)); } private static Stream isomorphicProvider() { - return Stream.of(Arguments.of("abbbbaac", "kffffkkd", true), Arguments.of("xyxyxy", "bnbnbn", true), Arguments.of("ghjknnmm", "wertpopo", false), Arguments.of("aaammmnnn", "ggghhhbbj", false)); + return Stream.of(Arguments.of("abbbbaac", "kffffkkd", Boolean.TRUE), Arguments.of("xyxyxy", "bnbnbn", Boolean.TRUE), Arguments.of("ghjknnmm", "wertpopo", Boolean.FALSE), Arguments.of("aaammmnnn", "ggghhhbbj", Boolean.FALSE)); } } From 78ed74da36c51ba92c49c8035cd869bcd987d322 Mon Sep 17 00:00:00 2001 From: Raveendra Pujari <72726513+raveendra11@users.noreply.github.com> Date: Tue, 3 Jun 2025 16:48:20 -0500 Subject: [PATCH 5/7] Update src/test/java/com/thealgorithms/strings/IsomorphicTest.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com> --- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 18f358d04e23..12b00c7c1597 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -16,6 +16,7 @@ public void testCheckStrings(String str1, String str2, Boolean expected) { } private static Stream isomorphicProvider() { - return Stream.of(Arguments.of("abbbbaac", "kffffkkd", Boolean.TRUE), Arguments.of("xyxyxy", "bnbnbn", Boolean.TRUE), Arguments.of("ghjknnmm", "wertpopo", Boolean.FALSE), Arguments.of("aaammmnnn", "ggghhhbbj", Boolean.FALSE)); + return Stream.of(Arguments.of("", "", Boolean.TRUE), Arguments.of("", "a", Boolean.FALSE), Arguments.of("aaa", "aa", Boolean.FALSE), Arguments.of("abbbbaac", "kffffkkd", Boolean.TRUE), Arguments.of("xyxyxy", "bnbnbn", Boolean.TRUE), Arguments.of("ghjknnmm", "wertpopo", Boolean.FALSE), + Arguments.of("aaammmnnn", "ggghhhbbj", Boolean.FALSE)); } } From af5e191d1cb8d8090031575fe1fc5fa30a4ca5a4 Mon Sep 17 00:00:00 2001 From: Raveendra Pujari <72726513+raveendra11@users.noreply.github.com> Date: Tue, 3 Jun 2025 16:48:28 -0500 Subject: [PATCH 6/7] Update src/test/java/com/thealgorithms/strings/IsomorphicTest.java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com> --- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 12b00c7c1597..d46016ccaf0b 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -13,6 +13,7 @@ public final class IsomorphicTest { @MethodSource("isomorphicProvider") public void testCheckStrings(String str1, String str2, Boolean expected) { assertEquals(expected, Isomorphic.checkStrings(str1, str2)); + assertEquals(expected, Isomorphic.checkStrings(str2, str1)); } private static Stream isomorphicProvider() { From afaa9e4307ced316cf50b054aa690d9a79104f2c Mon Sep 17 00:00:00 2001 From: Raveendra Pujari Date: Tue, 3 Jun 2025 17:01:33 -0500 Subject: [PATCH 7/7] method name changed to inputs --- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index d46016ccaf0b..4dd13fbc34ee 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -10,13 +10,13 @@ public final class IsomorphicTest { @ParameterizedTest - @MethodSource("isomorphicProvider") + @MethodSource("inputs") public void testCheckStrings(String str1, String str2, Boolean expected) { assertEquals(expected, Isomorphic.checkStrings(str1, str2)); assertEquals(expected, Isomorphic.checkStrings(str2, str1)); } - private static Stream isomorphicProvider() { + private static Stream inputs() { return Stream.of(Arguments.of("", "", Boolean.TRUE), Arguments.of("", "a", Boolean.FALSE), Arguments.of("aaa", "aa", Boolean.FALSE), Arguments.of("abbbbaac", "kffffkkd", Boolean.TRUE), Arguments.of("xyxyxy", "bnbnbn", Boolean.TRUE), Arguments.of("ghjknnmm", "wertpopo", Boolean.FALSE), Arguments.of("aaammmnnn", "ggghhhbbj", Boolean.FALSE)); }