Skip to content

Commit d6a00e7

Browse files
kjcmpirnat
authored andcommitted
Test-name fixes (gregmalcolm#139)
* about_method_bindings: Fixed test name. In the Python 3 version, the function test_set_descriptor_changes_behavior_of_attribute_assignment was named: test_set_descriptor_changes_behavior_of_attribute_assignment_changes --- with an extra "_changes" at the end. Renamed it to match the more sensible Python 2 version's name. * python3/koans/about_inheritance: Fixed test name. Removed extra 'this_' left over from the Python 2 version of test: test_this_all_classes_in_python_3_ultimately_inherit_from_object_class renamed to: test_all_classes_in_python_3_ultimately_inherit_from_object_class.
1 parent 95736d3 commit d6a00e7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

python3/koans/about_inheritance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def bark(self):
2525
def test_subclasses_have_the_parent_as_an_ancestor(self):
2626
self.assertEqual(__, issubclass(self.Chihuahua, self.Dog))
2727

28-
def test_this_all_classes_in_python_3_ultimately_inherit_from_object_class(self):
28+
def test_all_classes_in_python_3_ultimately_inherit_from_object_class(self):
2929
self.assertEqual(__, issubclass(self.Chihuahua, object))
3030

3131
# Note: This isn't the case in Python 2. In that version you have
@@ -86,4 +86,4 @@ def test_base_init_does_not_get_called_automatically(self):
8686

8787
def test_base_init_has_to_be_called_explicitly(self):
8888
boxer = self.Greyhound("Boxer")
89-
self.assertEqual(__, boxer.name)
89+
self.assertEqual(__, boxer.name)

python3/koans/about_method_bindings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def __set__(self, obj, val):
8383

8484
color = SuperColor()
8585

86-
def test_set_descriptor_changes_behavior_of_attribute_assignment_changes(self):
86+
def test_set_descriptor_changes_behavior_of_attribute_assignment(self):
8787
self.assertEqual(None, self.color.choice)
8888
self.color = 'purple'
8989
self.assertEqual(__, self.color.choice)

0 commit comments

Comments
 (0)