Fix build in Windows.

plusvic · web-flow · commit a74cf3f63172 · 2022-12-19T17:49:56.000+01:00
diff --git a/README.rst b/README.rst
@@ -1,5 +1,3 @@
-.. image:: https://travis-ci.org/VirusTotal/yara-python.svg
-    :target: https://travis-ci.org/VirusTotal/yara-python
 .. image:: https://ci.appveyor.com/api/projects/status/gidnb9ulj3rje5s2?svg=true
     :target: https://ci.appveyor.com/project/plusvic/yara-python
 
diff --git a/setup.py b/setup.py
@@ -76,12 +76,13 @@ def muted(*streams):
     devnull.close()
 
 
-def has_function(function_name, include_dirs=None, libraries=None, library_dirs=None):
+def has_function(function_name, includes=None, include_dirs=None, libraries=None, library_dirs=None):
   """Checks if a given functions exists in the current platform."""
   compiler = distutils.ccompiler.new_compiler()
   with muted(sys.stdout, sys.stderr):
       result = compiler.has_function(
           function_name,
+          includes=includes,
           include_dirs=include_dirs,
           libraries=libraries,
           library_dirs=library_dirs)
@@ -188,12 +189,6 @@ def run(self):
 
     exclusions = []
 
-    # Needed to build tlsh
-    module.define_macros.extend([('BUCKETS_128', 1), ('CHECKSUM_1B', 1)])
-
-    # Needed to build authenticode parser
-    module.libraries.append('ssl')
-
     for define in self.define or []:
       module.define_macros.append(define)
 
@@ -206,6 +201,22 @@ def run(self):
     building_for_freebsd = 'freebsd' in self.plat_name
     building_for_openbsd = 'openbsd' in self.plat_name # need testing
 
+    if building_for_windows:
+      arch = 'x86' if self.plat_name == 'win32' else 'x64'
+      openssl_include_dirs = [
+        os.path.join(base_dir, 'yara\\windows\\vs2015\\packages\\YARA.OpenSSL.{}.1.1.1\\include'.format(arch)),
+        os.path.join(base_dir, 'yara\\windows\\vs2017\\packages\\YARA.OpenSSL.{}.1.1.1\\include'.format(arch))
+      ]
+      openssl_library_dirs = [
+        os.path.join(base_dir, 'yara\\windows\\vs2015\\packages\\YARA.OpenSSL.{}.1.1.1\\lib'.format(arch)),
+        os.path.join(base_dir, 'yara\\windows\\vs2017\\packages\\YARA.OpenSSL.{}.1.1.1\\lib'.format(arch))
+      ]
+      openssl_libraries = ['libcrypto']
+    else:
+      openssl_include_dirs = []
+      openssl_library_dirs = []
+      openssl_libraries = ['crypto']
+
     if building_for_linux:
       module.define_macros.append(('_GNU_SOURCE', '1'))
       module.define_macros.append(('USE_LINUX_PROC', '1'))
@@ -264,17 +275,32 @@ def run(self):
     if self.dynamic_linking:
       module.libraries.append('yara')
     else:
-      if not self.define or not ('HASH_MODULE', '1') in self.define:
-        if (has_function('MD5_Init', include_dirs=module.include_dirs, libraries=['crypto'], library_dirs=module.library_dirs) and
-            has_function('SHA256_Init', include_dirs=module.include_dirs, libraries=['crypto'], library_dirs=module.library_dirs)):
-          module.define_macros.append(('HASH_MODULE', '1'))
-          module.define_macros.append(('HAVE_LIBCRYPTO', '1'))
-          module.libraries.append('crypto')
-        elif building_for_windows:
-          module.define_macros.append(('HASH_MODULE', '1'))
-          module.define_macros.append(('HAVE_WINCRYPT_H', '1'))
-        else:
-          exclusions.append('yara/libyara/modules/hash/hash.c')
+      # Is OpenSSL available?
+      if (has_function('OpenSSL_add_all_algorithms',
+                       includes=['openssl/evp.h'],
+                       include_dirs=module.include_dirs + openssl_include_dirs,
+                       libraries=module.libraries + openssl_libraries,
+                       library_dirs=module.library_dirs + openssl_library_dirs)
+          # In case OpenSSL is being linked statically
+          or has_function('OpenSSL_add_all_algorithms',
+                       includes=['openssl/evp.h'],
+                       include_dirs=module.include_dirs + openssl_include_dirs,
+                       libraries=module.libraries + openssl_libraries + ['dl', 'pthread', 'z'],
+                       library_dirs=module.library_dirs + openssl_library_dirs)
+          ):
+        module.define_macros.append(('HASH_MODULE', '1'))
+        module.define_macros.append(('HAVE_LIBCRYPTO', '1'))
+        module.libraries.extend(openssl_libraries)
+        module.include_dirs.extend(openssl_include_dirs)
+        module.library_dirs.extend(openssl_library_dirs)
+      elif building_for_windows:
+        # OpenSSL is not available, but in Windows we can rely on Wincrypt.
+        module.define_macros.append(('HASH_MODULE', '1'))
+        module.define_macros.append(('HAVE_WINCRYPT_H', '1'))
+      else:
+        # OpenSSL is not available, exclude hash.c, as it requires some hashing 
+        # functions.
+        exclusions.append('yara/libyara/modules/hash/hash.c')
 
       if self.enable_magic:
         module.define_macros.append(('MAGIC_MODULE', '1'))

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-.. image:: https://travis-ci.org/VirusTotal/yara-python.svg`
`2`		`- :target: https://travis-ci.org/VirusTotal/yara-python`
`3`	`1`	`.. image:: https://ci.appveyor.com/api/projects/status/gidnb9ulj3rje5s2?svg=true`
`4`	`2`	`:target: https://ci.appveyor.com/project/plusvic/yara-python`
`5`	`3`