Replies: 2 comments 3 replies
-
|
struggles with asset provisioning keep cropping up: #8302, #8361. i've also come to realize another advantage of an assets-included mode: it would be possible to have single-file setups for demonstrations and bug reproduction. AFAICT the current template is missing assets. |
Beta Was this translation helpful? Give feedback.
-
|
This contradicts your other statement though where you'd want fewer dependencies. The problem with this approach is we have to lock in at least two dependencies for CSS and JS whether you use it or not. There are many options and people don't want to include what they don't use. I think going with one approach would be easier and ideal. I'm not sure the bug report template script would be ideal for that. Rails doesn't use assets in there scripts. It was easier before because of Sprockets and asset gems. A lot has changed. |
Beta Was this translation helpful? Give feedback.
-
|
@javierjulio i don't quite understand how this would add dependencies, but perhaps my idea on how to include the assets wasn't clear. it is roughly this:
this would require zero asset-related dependencies on the end-user side. i'd be willing to try to do this in a PR, or maybe make my own gem that does this if you consider it scope creep. |
Beta Was this translation helpful? Give feedback.
-
|
The problem with this approach is it would conflict with any user style changes on the app side. They wouldn't be able to make Tailwind changes and have it apply safely either, it would conflict. I made a deliberate choice not to do this. It makes sense for Sidekiq because the styles are not meant to change but thats not the case here. You are more than welcome to try something in your fork and share a POC. I'd love to see it in action. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
I've made a gem to do this: activeadmin_assets. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
i think it could benefit activeadmin's popularity to have less dependencies.
with more and more rails apps being API-only, activeadmin is now probably one of the major reasons why people set up sprockets in their apps, which seems a bit wasteful just to compile JS that doesn't usually change.
on the CSS side, installing sassc always used to be a bit of a nuisance with its tricky compilation. the activeadmin v4 way, however, of having to install node + node modules + running a yarn watcher alongside rails, feels like an even bigger burden, especially if this is just to compile some CSS that doesn't usually change, and it does lead to some struggles as seen in #7947, #8223, #8226.
people have come up with hacks to work around this. this blog describes how to use tailwindcss-rails to circumvent the node requirement, restoring roughly the level of "comfort" that sassc used to provide. some people have forked AA with the assets included. others have monkeypatched the asset tag helpers to render CDN URLs instead. what would be ideal, IMHO, was if AA itself were to offer some lightweight and convenient way to render itself ...
Beta Was this translation helpful? Give feedback.
All reactions