Merge pull request alejandrodevs#2 from ignoch/master

alejandrodevs · alejandrodevs · commit d36090daafed · 2013-08-29T07:35:06.000-07:00
changing column value to transform sqlserver boolean as numbers
diff --git a/lib/mass_insert/builder/adapters/helpers/column_value.rb b/lib/mass_insert/builder/adapters/helpers/column_value.rb
@@ -76,12 +76,12 @@ def mysql2_column_value_boolean
             column_value ? "true" : "false"
           end
           alias :postgresql_column_value_boolean :mysql2_column_value_boolean
-          alias :sqlserver_column_value_boolean  :mysql2_column_value_boolean
 
           # Returns the column value to boolean column to sqlite database.
           def sqlite3_column_value_boolean
             column_value ? "1" : "0"
           end
+          alias :sqlserver_column_value_boolean  :sqlite3_column_value_boolean
 
         end
       end
diff --git a/spec/lib/mass_insert/builder/adapters/helpers/column_value_spec.rb b/spec/lib/mass_insert/builder/adapters/helpers/column_value_spec.rb
@@ -180,7 +180,6 @@
   [
     :mysql2,
     :postgresql,
-    :sqlserver,
   ].each do |adapter|
     method = :"#{adapter}_column_value_boolean"
 
@@ -205,22 +204,29 @@
     end
   end
 
-  describe "#sqlite3_column_value_boolean" do
-    it "should respond to sqlite3_column_value_boolean method" do
-      expect(subject).to respond_to(:sqlite3_column_value_boolean)
-    end
+  [
+    :sqlite3,
+    :sqlserver,
+  ].each do |adapter|
+    method = :"#{adapter}_column_value_boolean"
 
-    context "when column_value method return true value" do
-      it "should return true string" do
-        subject.stub(:column_value).and_return(true)
-        expect(subject.sqlite3_column_value_boolean).to eq("1")
+    describe "##{method.to_s}" do
+      it "should respond to #{method.to_s} method" do
+        expect(subject).to respond_to(method)
       end
-    end
 
-    context "when column_value method return false value" do
-      it "should return false string" do
-        subject.stub(:column_value).and_return(false)
-        expect(subject.sqlite3_column_value_boolean).to eq("0")
+      context "when column_value method return true value" do
+        it "should return true string" do
+          subject.stub(:column_value).and_return(true)
+          expect(subject.send(method)).to eq("1")
+        end
+      end
+
+      context "when column_value method return false value" do
+        it "should return false string" do
+          subject.stub(:column_value).and_return(false)
+          expect(subject.send(method)).to eq("0")
+        end
       end
     end
   end
