[VarDumper] Keep a ref to objects to ensure their handle cannot be reused while cloning

nicolas-grekas · nicolas-grekas · commit 29a06831078d · 2019-02-22T21:52:27.000+01:00
diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php
@@ -33,6 +33,7 @@ protected function doClone($var)
         $indexedArrays = [];       // Map of queue indexes that hold numerically indexed arrays
         $hardRefs = [];            // Map of original zval hashes to stub objects
         $objRefs = [];             // Map of original object handles to their stub object counterpart
+        $objects = [];             // Keep a ref to objects to ensure their handle cannot be reused while cloning
         $resRefs = [];             // Map of original resource handles to their stub object counterpart
         $values = [];              // Map of stub objects' hashes to original values
         $maxItems = $this->maxItems;
@@ -200,6 +201,7 @@ protected function doClone($var)
                         }
                         if (empty($objRefs[$h])) {
                             $objRefs[$h] = $stub;
+                            $objects[] = $v;
                         } else {
                             $stub = $objRefs[$h];
                             ++$stub->refCount;
