Use Ruby NotImplementedError exception as it exists since Ruby 1.9

Nicolas Rodriguez · Nicolas Rodriguez · commit be332cca12e6 · 2017-07-19T01:33:03.000+02:00
diff --git a/lib/ajax-datatables-rails/base.rb b/lib/ajax-datatables-rails/base.rb
@@ -1,6 +1,4 @@
 module AjaxDatatablesRails
-  class NotImplemented < StandardError; end
-
   class Base
     extend Forwardable
 
@@ -24,15 +22,15 @@ def datatable
     end
 
     def view_columns
-      fail(NotImplemented, view_columns_error_text)
+      fail(NotImplementedError, view_columns_error_text)
     end
 
     def get_raw_records
-      fail(NotImplemented, raw_records_error_text)
+      fail(NotImplementedError, raw_records_error_text)
     end
 
     def data
-      fail(NotImplemented, data_error_text)
+      fail(NotImplementedError, data_error_text)
     end
 
     def additional_datas
diff --git a/spec/ajax-datatables-rails/base_spec.rb b/spec/ajax-datatables-rails/base_spec.rb
@@ -21,7 +21,7 @@
     describe '#view_columns' do
       it 'raises an error if not defined by the user' do
         datatable = described_class.new(view)
-        expect { datatable.view_columns }.to raise_error AjaxDatatablesRails::NotImplemented
+        expect { datatable.view_columns }.to raise_error NotImplementedError
       end
 
       context 'child class implements view_columns' do
@@ -35,14 +35,14 @@
     describe '#get_raw_records' do
       it 'raises an error if not defined by the user' do
         datatable = described_class.new(view)
-        expect { datatable.get_raw_records }.to raise_error AjaxDatatablesRails::NotImplemented
+        expect { datatable.get_raw_records }.to raise_error NotImplementedError
       end
     end
 
     describe '#data' do
       it 'raises an error if not defined by the user' do
         datatable = described_class.new(view)
-        expect { datatable.data }.to raise_error AjaxDatatablesRails::NotImplemented
+        expect { datatable.data }.to raise_error NotImplementedError
       end
 
       context 'when data is defined as a hash' do
