Skip to content

Commit 45d3393

Browse files
mripardpopcornmix
authored andcommitted
drm/connector: Set DDC pointer in drmm_connector_init
Commit 35a3b82 ("drm/connector: Introduce drmm_connector_init") introduced the function drmm_connector_init() with a parameter for an optional ddc pointer to the i2c controller used to access the DDC bus. However, the underlying call to __drm_connector_init() was always setting it to NULL instead of passing the ddc argument around. This resulted in unexpected null pointer dereference on platforms expecting to get a DDC controller. Fixes: 35a3b82 ("drm/connector: Introduce drmm_connector_init") Signed-off-by: Maxime Ripard <maxime@cerno.tech>
1 parent a79d280 commit 45d3393

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_connector.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ int drmm_connector_init(struct drm_device *dev,
422422
if (drm_WARN_ON(dev, funcs && funcs->destroy))
423423
return -EINVAL;
424424

425-
ret = __drm_connector_init(dev, connector, funcs, connector_type, NULL);
425+
ret = __drm_connector_init(dev, connector, funcs, connector_type, ddc);
426426
if (ret)
427427
return ret;
428428

0 commit comments

Comments
 (0)