Fixed incorrect check that meant the URL was being parsed on every call to segment, attr, param etc

allmarkedup · allmarkedup · commit 472315f02afb · 2010-08-25T16:07:51.000+01:00
diff --git a/jquery.url.js b/jquery.url.js
@@ -64,7 +64,7 @@ jQuery.url = function()
      */		
 	var key = function( key )
 	{
-		if ( ! parsed.length )
+		if ( jQuery.isEmptyObject(parsed) )
 		{
 			setUp(); // if the URI has not been parsed yet then do this first...	
 		} 
@@ -90,7 +90,7 @@ jQuery.url = function()
      */		
 	var param = function( item )
 	{
-		if ( ! parsed.length )
+		if ( jQuery.isEmptyObject(parsed) )
 		{
 			setUp(); // if the URI has not been parsed yet then do this first...	
 		}
@@ -154,7 +154,7 @@ jQuery.url = function()
 	     */	
 		segment : function( pos )
 		{
-			if ( ! parsed.length )
+			if ( jQuery.isEmptyObject(parsed) )
 			{
 				setUp(); // if the URI has not been parsed yet then do this first...	
 			} 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ jQuery.url = function()`
`64`	`64`	`*/`
`65`	`65`	`var key = function( key )`
`66`	`66`	`{`
`67`		`- if ( ! parsed.length )`
	`67`	`+ if ( jQuery.isEmptyObject(parsed) )`
`68`	`68`	`{`
`69`	`69`	`setUp(); // if the URI has not been parsed yet then do this first...`
`70`	`70`	`}`
`@@ -90,7 +90,7 @@ jQuery.url = function()`
`90`	`90`	`*/`
`91`	`91`	`var param = function( item )`
`92`	`92`	`{`
`93`		`- if ( ! parsed.length )`
	`93`	`+ if ( jQuery.isEmptyObject(parsed) )`
`94`	`94`	`{`
`95`	`95`	`setUp(); // if the URI has not been parsed yet then do this first...`
`96`	`96`	`}`
`@@ -154,7 +154,7 @@ jQuery.url = function()`
`154`	`154`	`*/`
`155`	`155`	`segment : function( pos )`
`156`	`156`	`{`
`157`		`- if ( ! parsed.length )`
	`157`	`+ if ( jQuery.isEmptyObject(parsed) )`
`158`	`158`	`{`
`159`	`159`	`setUp(); // if the URI has not been parsed yet then do this first...`
`160`	`160`	`}`