-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Closed as not planned
Labels
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgentarea: service-workerIssues related to the @angular/service-worker packageIssues related to the @angular/service-worker packagebrowser: safaristate: confirmedtype: bug/fix
Milestone
Description
🐞 bug report
Affected Package
The issue is caused by package @angular/service-worker
Is this a regression?
I don't know
Description
The swPush requestSubscription break on SAFARI browser
🔬 Minimal Reproduction
import { Optional, Injectable } from '@angular/core';
import { HttpClient } from '@angular/common/http';
import { SwPush } from '@angular/service-worker';
import { Observable } from 'rxjs';
import { environment } from '../../environments/environment';
import { PushNotification } from './notification';
@Injectable({
providedIn: 'root'
})
export class NotificationService {
constructor(
private http: HttpClient,
@Optional() private swPush: SwPush
) { }
activate(): Observable<void> {
return Observable.create((observer) => {
this.swPush.requestSubscription({
serverPublicKey: environment.webPush.publicKey
}).then((subscription: PushSubscription) => {
this.http.post(`${environment.serverUrl}/subscription`, subscription).subscribe(() => {
observer.next();
observer.complete();
}, (err) => {
observer.error(err);
});
}).catch((err) => {
console.log(err): // => Here an error occurs on Safari : TypeError: undefined is not an object (evaluating 't.subscribe')
observer.error(err);
});
});
}
sendNotification(notification: PushNotification): Observable<void> {
return this.http.post<void>(`${environment.serverUrl}/notification`, notification);
}
messages(): Observable<PushNotification> {
return <Observable<PushNotification>>this.swPush.messages;
}
}
🔥 Exception or Error
TypeError: undefined is not an object (evaluating 't.subscribe')
🌍 Your Environment
Angular Version:
Angular CLI: 7.1.4
Node: 8.11.3
OS: darwin x64
Angular: 7.1.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.11.4
@angular-devkit/build-angular 0.11.4
@angular-devkit/build-optimizer 0.11.4
@angular-devkit/build-webpack 0.11.4
@angular-devkit/core 7.1.4
@angular-devkit/schematics 7.1.4
@angular/cdk 7.2.0
@angular/material 7.2.0
@angular/pwa 0.11.4
@ngtools/webpack 7.1.4
@schematics/angular 7.1.4
@schematics/update 0.11.4
rxjs 6.3.3
typescript 3.1.6
webpack 4.23.1
AND :
"@angular/service-worker": "~7.1.0",
Anything else relevant?
This issue is on Safari browser Version 12.0.2 (13606.3.4.1.4)
Metadata
Metadata
Assignees
Labels
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgentarea: service-workerIssues related to the @angular/service-worker packageIssues related to the @angular/service-worker packagebrowser: safaristate: confirmedtype: bug/fix