-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Closed as not planned
Closed as not planned
Copy link
Labels
Milestone
Description
Is this a bug report or a feature request?
- Bug Report
- Feature Request
Please provide the steps to reproduce the issue [Bug Report only]
There's a whole directory for cypress tests along with config files which might be dead code. My guess is that might become dead after moving from package.json to bazel, since - according to git blame - the appropriate cypress commands used to be there in the repo. And now in https://github.com/angular/angular/blob/main/devtools/BUILD.bazel#L8 only cypress.json is exported, but no commands seem to be run.
I was thinking of providing end-to-end (or at least wide scope integration tests) for devtools anyway.
PS This is an issue (not a PR) since I don't know which direction should we move forward.
Please provide the expected behavior vs the actual behavior you encountered [Bug Report only]
Either we make cypress executable or we remove the tests entirely.
Please provide a screenshot if possible [Bug Report only]
No response
Please provide the exception or error you saw [Bug Report only]
No response
Is this a browser-specific issue? If so, please specify the device, browser, and version. [Bug Report only]
No response
Description [Feature Request only]
No response
Proposed solution [Feature Request only]
No response
Alternatives considered [Feature Request only]
No response