The rest of the built-in validators #61758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
reviewed
May 29, 2025
| * @param path Path to the target field | ||
| * @param config Optional, currently allows providing custom errors function. | ||
| */ | ||
| export function requiredTrue(path: FieldPath<boolean>, config?: BaseValidatorConfig<boolean>) { |
There was a problem hiding this comment.
do we need this? this just feels like it should be required with a FieldPath<boolean>
There was a problem hiding this comment.
I've been looking at signal forms and it is pretty interesting so far. Noticed this comment, and maybe you already know this, but the requiredTrue is mainly useful for checkboxes, where you might require a checkbox to be checked. A required validator for a checkbox would allow a false value, but not undefined/null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.