-
Notifications
You must be signed in to change notification settings - Fork 26.4k
docs(docs-infra): generate llms-full at build time #61864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71eda6c
to
8f9044b
Compare
fa2ba4e
to
9a58a8b
Compare
7db105a
to
5239329
Compare
5239329
to
21b56a5
Compare
adev/src/context/BUILD.bazel
Outdated
copy_to_directory( | ||
name = "llms_full", | ||
srcs = [":run_generate_llms_full"], | ||
out = "llm-files", | ||
replace_prefixes = {"**/": ""}, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super happy with what I achieved with this rule but at least it works.
Ideally I would have wanted to generate the file directly at src/llms-full.txt
where llms.txt
is already located.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty clean to me. Why can't this live in adev/src/BUILD
? or in adev/BUILD
to output directly in src/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered offline, we get a bunch of errors.
We'll take care of it in a follow-up
Deployed adev-preview for b9f12dc to: https://ng-dev-previews-fw--pr-angular-angular-61864-adev-prev-livqrqbu.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
21b56a5
to
a948410
Compare
adev/src/context/BUILD.bazel
Outdated
copy_to_directory( | ||
name = "llms_full", | ||
srcs = [":run_generate_llms_full"], | ||
out = "llm-files", | ||
replace_prefixes = {"**/": ""}, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty clean to me. Why can't this live in adev/src/BUILD
? or in adev/BUILD
to output directly in src/
?
This PR was merged into the repository by commit a1f8cc4. The changes were merged into the following branches: main, 20.1.x |
No description provided.